Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-images-4][editorial] Improved examples for stripes() function #9749

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

SebastianZ
Copy link
Contributor

I've made the changes I've mentioned in #9719. That is, SVGs are used instead of PNGs, the file names have been aligned with the rest of the assets and the alternative text has been removed because it's unnecessary because the description of the images is right above them.

Sebastian

Used SVGs instead of PNGs, aligned the file names with the rest of the assets and removed the alternative text because it's unnecessary.
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave the height as 1em so it scales with text. Otherwise looks good.

@francescorn
Copy link
Contributor

francescorn commented Dec 27, 2023

I am wondering why the stripes() examples should be svgs, the other images are pngs in the draft.

@SebastianZ
Copy link
Contributor Author

I would leave the height as 1em so it scales with text. Otherwise looks good.

I've changed them to be 1em high, though note that this is counter-productive when users have chosen a different font size than 16px because the images then get stretched vertically which let's the text "transparent" appear stretched as well.

Sebastian

@SebastianZ SebastianZ merged commit af302b4 into w3c:main Dec 27, 2023
1 check passed
@SebastianZ
Copy link
Contributor Author

SebastianZ commented Dec 27, 2023

I am wondering why the stripes() examples should be svgs, the other images are pngs in the draft.

I only did that for the stripes() example images because they were added lately. The others may also benefit from being replaced by SVGs but note that not all of them can actually be represented as SVGs. Only the ones that show features current browsers actually support should be replaced.

Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants