[css-view-transitions-1] Exclude auto as custom ident for view-transition-name #9895
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is inconsistent with how other specs define custom ident restrictions.
nt1m
approved these changes
Feb 7, 2024
|
nt1m marked as non substantive for IPR from ash-nazg. |
|
Out of curiosity, what is the reason to exclude |
We were thinking of potentially reserving this keyword for in case we'd want to auto-generate names, but in general there's no real reason to name a view transition "auto". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, below
view-transition-name, defined withnone | auto | <custom-ident>:https://drafts.csswg.org/css-view-transitions-1/#valdef-view-transition-name-custom-ident
This PR adds
autoas an excluded<custom-ident>value.