New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-text-4] Add note about deviations from UAX-14 #9997
base: main
Are you sure you want to change the base?
Conversation
This is editorial, but could you consider reformatting this to use Semantic Linefeeds, as described in https://rhodesmill.org/brandon/2012/one-sentence-per-line/, to match the source formatting style of the rest of the document? |
@birtles your GitHub account doesn't seem to be associated with your W3C account. At least I think that's why the IPR check fails. Could you double check on that? |
@frivoal Huh that's odd. It's always worked for me in the past. I checked my W3C account and it has the correct GitHub account there. I'm still in the W3C org on GitHub too. I suspect it's a bug in the IPR check task. It looks like it hasn't run? |
Let me try closing and reopening the PR to see if that wakes up the bot |
Thanks! That seems to have done the trick. Sorry, I missed your comment about semantic line breaks. (I have my email filtering out all CSS notifications that don't mention animations or transitions 😅). Is there still something that needs to be done there? I thought it was already using semantic line breaks for the most part. Is it just the first sentence that needs better breaking? |
Yes, the rest is indeed fine, but the first sentence could be wrapped better (e.g., after "starting point", after the comma, after desirable). |
Thanks! Done! |
@fantasai how does this look to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Squash-merge if @jfkthame approves. :)
Fixes #9432