This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
[css-flexbox] Fix flex-flexitem-percentage-prescation-ref.html #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic validation checks of commit d611348 passed. |
Automatic validation checks of commit e8d755f passed. |
In truth I don't understand this test, or why its <title> is what it is, but at least this makes the reference match the testcase. I can only assume that it was written before fractional pixels were common?
Automatic validation checks of commit 8012214 passed. |
|
Not sure 101px is intentional or not, but the fix lgtm. |
kojiishi
added a commit
that referenced
this pull request
Sep 30, 2015
[css-flexbox] Fix flex-flexitem-percentage-prescation-ref.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In truth I don't understand this test, or why its <title> is what it is,
but at least this makes the reference match the testcase. I can only assume
that it was written before fractional pixels were common?