Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

[css-flexbox] Add a test for negative margin handling #919

Merged
merged 1 commit into from Oct 30, 2016

Conversation

cbiesinger
Copy link

@tabatkins @fantasai please review!

Review on Reviewable

@syncbot
Copy link
Collaborator

syncbot commented Oct 15, 2015

Automatic validation checks of commit 0b63217 discovered the following problem:

In css-flexbox-1/reference/negative-margins-001-ref.html:

  • No author specified.

@syncbot
Copy link
Collaborator

syncbot commented Oct 15, 2015

Automatic validation checks of commit 7a25a4b passed.

@tabatkins
Copy link
Member

css-flexbox-1/negative-margins-001.html, line 17 [r1] (raw file):
Move the border to .container, to make it easier to tell if the flex container is less or greater than 60px.


Comments from the review on Reviewable.io

@syncbot
Copy link
Collaborator

syncbot commented Oct 15, 2015

Automatic validation checks of commit 0026c90 passed.

@cbiesinger
Copy link
Author

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


css-flexbox-1/negative-margins-001.html, line 17 [r1] (raw file):
Done.


Comments from the review on Reviewable.io

@gsnedders
Copy link
Contributor

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@gsnedders
Copy link
Contributor

Review status: all files reviewed at latest revision, 1 unresolved discussion.


css-flexbox-1/negative-margins-001.html, line 17 at r1 (raw file):

Previously, cbiesinger (Christian Biesinger) wrote…

Done.

LGTM

Comments from Reviewable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants