Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaulting name to percent-encoded title creates invalid name #388

Closed
gkellogg opened this issue Mar 22, 2015 · 4 comments · Fixed by #399
Closed

defaulting name to percent-encoded title creates invalid name #388

gkellogg opened this issue Mar 22, 2015 · 4 comments · Fixed by #399

Comments

@gkellogg
Copy link
Member

If the name property does not exist, it's property value is taken by percent-encoding the title, as necessary. However '%' is not a in the valid character range for name, or in a URI Template.

There is also the need to un-encode name when used as the value of the _name variable, but this will not be possible without percent encoding.

@iherman
Copy link
Member

iherman commented Mar 25, 2015

I do not understand. The variable definition in the template spec says:

variable-list =  varspec *( "," varspec )
varspec       =  varname [ modifier-level4 ]
varname       =  varchar *( ["."] varchar )
varchar       =  ALPHA / DIGIT / "_" / pct-encoded

and pct-encoded is defined, in the notational conventions' section as one would expect.

I may miss something but I do not see the problem(s).

@JeniT
Copy link

JeniT commented Mar 25, 2015

+1 to @iherman - I propose we update the definition of the allowed syntax of name to include the possibility of percent-encoded characters.

@gkellogg
Copy link
Member Author

Great, I had missed that percent encoded was allowed, but that makes perfect sense.

@gkellogg
Copy link
Member Author

Fixed in 5329c76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants