Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt "test as you commit" policy #48

Closed
anssiko opened this issue Oct 4, 2017 · 9 comments
Closed

Adopt "test as you commit" policy #48

anssiko opened this issue Oct 4, 2017 · 9 comments

Comments

@anssiko
Copy link
Member

anssiko commented Oct 4, 2017

Recently, there has been movement toward requiring a test change whenever a normative
spec change is landed.

For example, the SVG WG Charter has the following text:

The SVG WG will follow a test as you commit approach to specification development, for specifications in CR or above.

I would suggest the DAS WG will consider adopting similar policy for its revised Charter.

@dontcallmedom
Copy link
Member

I don't know if I would necessarily codify it, but I would even suggest starting well before CR to apply that policy

@anssiko
Copy link
Member Author

anssiko commented Oct 4, 2017

Perhaps we could make this policy "must" for CR and above and "should" at earlier maturity levels. (Not sure if we can use RFC 2119 terms in the Charter -- just to make a point.)

I feel this policy would be very helpful at earlier spec maturity levels too especially if there are implementation(s).

If there's just a spec draft that is undergoing rapid iteration without an implementation the policy could be relaxed to keep the cost of iteration down. At the other end of the spectrum, the policy will help ensure specs do not enter CR too lightly since past that point spec churn will have a higher cost.

I think we do not need to codify these nuances, just do the Right Thing.

@dontcallmedom
Copy link
Member

maybe the existence of an implementation ought to be the trigger of making simultaneous test contributions expected?

anssiko added a commit to w3c/sensors that referenced this issue Oct 17, 2017
@foolip
Copy link
Member

foolip commented Oct 18, 2017

FWIW, I would leave CR out of the equation unless you think the distinction is really useful. As I understand from @plehegar, it was used for CSS and SVG as a bit of a compromise, and if the group wants to treat all specs the same, they can.

On must vs. should, we've just gone with "highly appreciated" in most places, which I think is a should. I can't really see that must would ever really be appropriate, it's always possible that there will be good reasons to not do testing, or do it later.

Will this issue be discussed at TPAC, or what's the next step?

@anssiko
Copy link
Member Author

anssiko commented Oct 18, 2017

@foolip, I personally like the "highly appreciated" wording. Is there some text we could borrow for charter purposes? Otherwise I'll propose something along those lines.

I'm happy to discuss this topic at TPAC too. Note DAS WG does not formally meet at TPAC. Some of us will still be around, so perhaps we could discuss and socialize the idea of "test as you commit" in https://www.w3.org/wiki/TPAC/2017/SessionIdeas#web-platform-tests breakout session, for example.

@foolip
Copy link
Member

foolip commented Oct 18, 2017

SVG is the only case I'm aware of where anything's been put into the charter, and it sais "The SVG WG will follow a test as you commit approach to specification development, for specifications in CR or above."

If you're about to recharter I guess that could make sense, otherwise maybe just update all of the repos, or create a group-wide CONTRIBUTING.md that all of the others point to?

If the group isn't meeting at TPAC and you don't expect any dissent, then I don't think there's any reason to wait for TPAC. But it's not up to me, I'm just a cheerleader here :)

@anssiko
Copy link
Member Author

anssiko commented Oct 18, 2017

Proposed text to the new DAS Charter: #51

Text borrowed from the SVG WG Charter.

anssiko added a commit that referenced this issue Oct 18, 2017
Fix #48: Adopt 'test as you commit' policy
@foolip
Copy link
Member

foolip commented Oct 18, 2017

Yay, thanks @anssiko!

I see the CR condition is in #51, what does that mean in practice? Should CONTRIBUTING.md of all individual specs still be updated?

@anssiko
Copy link
Member Author

anssiko commented Oct 19, 2017

@foolip, given this Charter is not yet in production, I suggest we test drive with the Generic Sensor API https://github.com/w3c/sensors/blob/master/CONTRIBUTING.md#tests and will get the policy adopted for all the group's deliverables automatically when the new Charter is in effect 1 February 2018 or so.

That said, nothing is preventing us from using the new policy already now for other specifications too. For example, https://www.w3.org/2009/dap/#sensors that inherit from Sensor will logically inherit this policy too.

I wouldn't worry too much about whether the CONTRIBUTING.md of each repo contains this text, we just have to do the right thing :-)

rakuco added a commit to rakuco/html-media-capture that referenced this issue Oct 23, 2017
See https://github.com/foolip/testing-in-standards/blob/master/policy.md
for context. This phrasing matches that used for many other specs'
CONTRIBUTING.md files.

See also: w3c/das-charter#48
anssiko pushed a commit to w3c/html-media-capture that referenced this issue Oct 23, 2017
See https://github.com/foolip/testing-in-standards/blob/master/policy.md
for context. This phrasing matches that used for many other specs'
CONTRIBUTING.md files.

See also: w3c/das-charter#48
rakuco added a commit to rakuco/accelerometer that referenced this issue Oct 23, 2017
See https://github.com/foolip/testing-in-standards/blob/master/policy.md
for context. This phrasing matches that used for many other specs'
CONTRIBUTING.md files.

This spec seems to be fairly stable, and is shipping in Chrome as part of
its Origin Trial process since Chrome 63.

See also: w3c/das-charter#48
rakuco added a commit to rakuco/orientation-sensor that referenced this issue Oct 23, 2017
See https://github.com/foolip/testing-in-standards/blob/master/policy.md
for context. This phrasing matches that used for many other specs'
CONTRIBUTING.md files.

This spec seems to be fairly stable, and is shipping in Chrome as part of
its Origin Trial process since Chrome 63.

See also: w3c/das-charter#48
rakuco added a commit to rakuco/orientation-sensor that referenced this issue Oct 23, 2017
See https://github.com/foolip/testing-in-standards/blob/master/policy.md
for context. This phrasing matches that used for many other specs'
CONTRIBUTING.md files.

This spec seems to be fairly stable, and an implementation is shipping in
Chrome as part of its Origin Trial process since Chrome 63.

See also: w3c/das-charter#48
rakuco added a commit to rakuco/accelerometer that referenced this issue Oct 23, 2017
See https://github.com/foolip/testing-in-standards/blob/master/policy.md
for context. This phrasing matches that used for many other specs'
CONTRIBUTING.md files.

This spec seems to be fairly stable, and an implementation is shipping in
Chrome as part of its Origin Trial process since Chrome 63.

See also: w3c/das-charter#48
alexshalamov pushed a commit to w3c/accelerometer that referenced this issue Oct 23, 2017
See https://github.com/foolip/testing-in-standards/blob/master/policy.md
for context. This phrasing matches that used for many other specs'
CONTRIBUTING.md files.

This spec seems to be fairly stable, and an implementation is shipping in
Chrome as part of its Origin Trial process since Chrome 63.

See also: w3c/das-charter#48
rakuco added a commit to rakuco/magnetometer that referenced this issue Oct 24, 2017
See https://github.com/foolip/testing-in-standards/blob/master/policy.md
for context. This phrasing matches that used for many other specs'
CONTRIBUTING.md files.

See also: w3c/das-charter#48
rakuco added a commit to rakuco/ambient-light that referenced this issue Oct 24, 2017
See https://github.com/foolip/testing-in-standards/blob/master/policy.md
for context. This phrasing matches that used for many other specs'
CONTRIBUTING.md files.

See also: w3c/das-charter#48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants