Adopt "test as you commit" policy #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed in w3c/das-charter#48
anssiko
requested review from
rwaldron,
dontcallmedom,
pozdnyakov and
alexshalamov
dontcallmedom
approved these changes
Oct 17, 2017
alexshalamov
approved these changes
Oct 18, 2017
|
There's strong support for adopting the "test as you commit" policy for the Generic Sensor API Level 1 spec, so we make this official. In practical terms, also the more stable concrete sensor specs with implementations will inherit this policy. Based on learnings from this specification, we plan to scale this policy to cover all the deliverables in the Device and Sensors WG. This global policy change to the group's Charter is tracked in w3c/das-charter#48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to adopt the "test as you commit" policy for the Generic Sensor API. As discussed in w3c/das-charter#48, the proposed plan is to adopt a similar policy for all Device and Sensors WG's deliverables in the long term.
I suggest we use the Generic Sensor API Level 1 as a test drive, since it is feature complete, has an implementation that is expected to be conformant, and most importantly a test suite that is nearly complete (missing tests for
hasReadingIIRC).The language highly appreciated is to say we have some leeway should we want to incubate e.g. Level 2 features without tests first.
Cc @rakuco @foolip @Honry