Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework audio description original and translation languages #179

Merged
merged 28 commits into from Dec 21, 2023
Merged

Rework audio description original and translation languages #179

Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
14fd2d6
Rework audio description original and translation languages
nigelmegitt Jul 31, 2023
4ac4335
Change Primary Language to Default Language, add Original Language
nigelmegitt Aug 3, 2023
a58512f
Remove notes about nominal language
nigelmegitt Aug 3, 2023
9f21618
Add `#originalLang-root` extension and require it
nigelmegitt Aug 3, 2023
9c59046
Change `daptm:langSrc` to use a BCP47 language code
nigelmegitt Sep 29, 2023
cf94249
Make Text Language Source optional
nigelmegitt Nov 2, 2023
57e79b1
Fix `langSrc` in example
nigelmegitt Nov 2, 2023
067fccb
Address review feedback
nigelmegitt Nov 16, 2023
7048307
Address @cconcolato review feedback
nigelmegitt Nov 21, 2023
493fdb2
as -> since
nigelmegitt Nov 21, 2023
01d26df
Address @cconcolato review feedback
nigelmegitt Nov 28, 2023
f8cf6e0
Fully specify `daptm:langSrc` including inheritance, allow empty string
nigelmegitt Nov 29, 2023
490dd02
Editorial improvements
nigelmegitt Nov 29, 2023
f098f95
Explicitly state the computed value is the specified value if present
nigelmegitt Nov 29, 2023
0fcf85e
Address @cconcolato 's feedback
nigelmegitt Dec 14, 2023
1068204
Make SVG valid
nigelmegitt Dec 15, 2023
0a6f969
remove codeline attributes that got away last time
nigelmegitt Dec 15, 2023
10b1a0e
Address some feedback
nigelmegitt Dec 19, 2023
2cf1e65
Simplify note about As-Recorded scripts
nigelmegitt Dec 19, 2023
74e4017
Extend `#xmlLang-root` to include Default Language requirements
nigelmegitt Dec 19, 2023
1693603
Delete Original Languages
nigelmegitt Dec 19, 2023
81b3618
Simplify Script Event requirement for zero or more text objects
nigelmegitt Dec 19, 2023
1c53025
Reorder bullets and para in Text Language Source
nigelmegitt Dec 19, 2023
d58c992
Explain how to identify if Text is Original or Translation.
nigelmegitt Dec 19, 2023
fa7ca74
Simplify language about "marking" translations
nigelmegitt Dec 19, 2023
106b951
Target implementers as well as authors in warning notes
nigelmegitt Dec 19, 2023
a1c80d4
Address editorial feedback comments from @cconcolato
nigelmegitt Dec 21, 2023
aad01da
Add note as suggested by @andreastai
nigelmegitt Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/event-desc-descType.xml
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
<body>
<div begin="10s" end="13s">
<ttm:desc daptm:descType="pronunciationNote">[oːnʲ]</ttm:desc>
<p daptm:langSrc="original">Eóin looks around at the other assembly members.</p>
<p>Eóin looks around at the other assembly members.</p>
</div>
</body>
...
8 changes: 4 additions & 4 deletions examples/event-desc-multiple-descType.xml
View file
Open in desktop
Expand Up @@ -3,20 +3,20 @@
<div begin="10s" end="13s">
<ttm:desc daptm:descType="scene">Scene 1</ttm:desc>
<ttm:desc daptm:descType="plotSignificance">High</ttm:desc>
<p daptm:langSrc="original">
<p xml:lang="en">
<span>A woman climbs into a small sailing boat.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>Une femme monte à bord d'un petit bateau à voile.</span>
</p>
</div>
<div begin="18s" end="20s">
<ttm:desc daptm:descType="scene">Scene 1</ttm:desc>
<ttm:desc daptm:descType="plotSignificance">Low</ttm:desc>
<p daptm:langSrc="original">
<p xml:lang="en">
<span>The woman pulls the tiller and the boat turns.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>La femme tire sur la barre et le bateau tourne.</span>
</p>
</div>
Expand Down
8 changes: 4 additions & 4 deletions examples/event-desc.xml
View file
Open in desktop
Expand Up @@ -2,19 +2,19 @@
<body>
<div begin="10s" end="13s">
<ttm:desc>Scene 1</ttm:desc>
<p daptm:langSrc="original">
<p xml:lang="en">
<span>A woman climbs into a small sailing boat.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>Une femme monte à bord d'un petit bateau à voile.</span>
</p>
</div>
<div begin="18s" end="20s">
<ttm:desc>Scene 1</ttm:desc>
<p daptm:langSrc="original">
<p xml:lang="en">
<span>The woman pulls the tiller and the boat turns.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>La femme tire sur la barre et le bateau tourne.</span>
</p>
</div>
Expand Down
8 changes: 5 additions & 3 deletions examples/intro-original-language-with-dub-language-and-adaptation.xml
View file
Open in desktop
@@ -1,8 +1,10 @@
<tt xmlns="http://www.w3.org/ns/ttml"
xmlns:ttm="http://www.w3.org/ns/ttml#metadata"
xmlns:ttp="http://www.w3.org/ns/ttml#parameter"
xmlns:daptm="http://www.w3.org/ns/ttml/profile/dapt#metadata"
xml:lang="en"
ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/dapt1.0/content"
xml:lang="en"
daptm:langSrc="fr"
daptm:workflowType="dubbing"
daptm:scriptType="preRecording">
<head>
Expand All @@ -14,10 +16,10 @@
</head>
<body>
<div begin="10s" end="13s" ttm:agent="character_1" daptm:onScreen="ON_OFF">
<p xml:lang="fr" daptm:langSrc="original">
<p xml:lang="fr" daptm:langSrc="fr">
<span>Et c'est grâce à ça qu'on va devenir riches.</span>
</p>
<p xml:lang="en" daptm:langSrc="translation">
<p xml:lang="en" daptm:langSrc="fr">
<span begin="0s">And thanks to that,</span><span begin="1.5s"> we're gonna get rich.</span>
</p>
</div>
Expand Down
8 changes: 5 additions & 3 deletions examples/intro-original-language-with-dub-language.xml
View file
Open in desktop
@@ -1,8 +1,10 @@
<tt xmlns="http://www.w3.org/ns/ttml"
xmlns:ttm="http://www.w3.org/ns/ttml#metadata"
xmlns:ttp="http://www.w3.org/ns/ttml#parameter"
xmlns:daptm="http://www.w3.org/ns/ttml/profile/dapt#metadata"
xml:lang="en"
ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/dapt1.0/content"
xml:lang="en"
daptm:langSrc="fr"
daptm:workflowType="dubbing"
daptm:scriptType="translatedTranscript">
<head>
Expand All @@ -14,10 +16,10 @@
</head>
<body>
<div begin="10s" end="13s" ttm:agent="character_1">
<p xml:lang="fr" daptm:langSrc="original">
<p xml:lang="fr" daptm:langSrc="fr"> <!-- original -->
<span>Et c'est grâce à ça qu'on va devenir riches.</span>
</p>
<p xml:lang="en" daptm:langSrc="translation">
<p xml:lang="en" daptm:langSrc="fr"> <!-- translated -->
<span>And thanks to that, we're gonna get rich.</span>
</p>
</div>
Expand Down
6 changes: 4 additions & 2 deletions examples/intro-original-language.xml
View file
Open in desktop
@@ -1,8 +1,10 @@
<tt xmlns="http://www.w3.org/ns/ttml"
xmlns:ttm="http://www.w3.org/ns/ttml#metadata"
xmlns:ttp="http://www.w3.org/ns/ttml#parameter"
xmlns:daptm="http://www.w3.org/ns/ttml/profile/dapt#metadata"
xml:lang="fr"
ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/dapt1.0/content"
xml:lang="fr"
daptm:langSrc="fr"
daptm:workflowType="dubbing"
daptm:scriptType="originalTranscript">
<head>
Expand All @@ -14,7 +16,7 @@
</head>
<body>
<div begin="10s" end="13s">
<p daptm:langSrc="original" ttm:agent="character_1">
<p ttm:agent="character_1">
<span>Et c'est grâce à ça qu'on va devenir riches.</span>
</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion examples/intro-script-with-embedded-audio.xml
View file
Open in desktop
@@ -1,6 +1,6 @@
...
<div begin="25s" end="28s">
<p daptm:langSrc="original">
<p>
<animate begin="0.0s" end="0.3s" tta:gain="1;0.39" fill="freeze"/>
<animate begin="2.7s" end="3s" tta:gain="0.39;1"/>
<span begin="0.3s" end="2.7s">
Expand Down
5 changes: 3 additions & 2 deletions examples/intro-script-with-gain.xml
View file
Open in desktop
@@ -1,10 +1,11 @@
<tt ...
daptm:workflowType="audioDescription"
daptm:scriptType="asRecorded"
xml:lang="en">
xml:lang="en"
daptm:langSrc="">
...
<div begin="25s" end="28s">
<p daptm:langSrc="original">
<p>
<animate begin="0.0s" end="0.3s" tta:gain="1;0.39" fill="freeze"/>
<animate begin="2.7s" end="3s" tta:gain="0.39;1"/>
<span begin="0.3s" end="2.7s">
Expand Down
2 changes: 1 addition & 1 deletion examples/intro-script-with-speak.xml
View file
Open in desktop
@@ -1,6 +1,6 @@
...
<div begin="18s" end="20s">
<p daptm:langSrc="original">
<p>
<span tta:speak="normal">
The woman pulls the tiller and the boat turns.</span>
</p>
Expand Down
9 changes: 5 additions & 4 deletions examples/intro-times-and-text.xml
View file
Open in desktop
Expand Up @@ -3,17 +3,18 @@
xmlns:daptm="http://www.w3.org/ns/ttml/profile/dapt#metadata"
xmlns:xml="http://www.w3.org/XML/1998/namespace"
ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/dapt1.0/content"
xml:lang="en"
daptm:langSrc=""
daptm:workflowType="audioDescription"
daptm:scriptType="preRecording"
xml:lang="en">
daptm:scriptType="preRecording">
<body>
<div begin="10s" end="13s">
<p daptm:langSrc="original">
<p>
A woman climbs into a small sailing boat.
</p>
</div>
<div begin="18s" end="20s">
<p daptm:langSrc="original">
<p>
The woman pulls the tiller and the boat turns.
</p>
</div>
Expand Down
3 changes: 2 additions & 1 deletion examples/intro-top-level.xml
View file
Open in desktop
@@ -1,8 +1,9 @@
<tt xmlns="http://www.w3.org/ns/ttml"
xmlns:ttp="http://www.w3.org/ns/ttml#parameter"
xmlns:daptm="http://www.w3.org/ns/ttml/profile/dapt#metadata"
xml:lang="en"
ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/dapt1.0/content"
xml:lang="en"
daptm:langSrc="en"
daptm:workflowType="dubbing"
daptm:scriptType="originalTranscript">
<head>
Expand Down