Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge model and TTML structure #49

Merged
merged 22 commits into from
Sep 23, 2022
Merged

Merge model and TTML structure #49

merged 22 commits into from
Sep 23, 2022

Conversation

cconcolato
Copy link
Contributor

@cconcolato cconcolato commented Sep 15, 2022 •
edited by pr-preview bot

nigelmegitt
nigelmegitt requested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as my comments, §6.1.3 and §6.1.4 need modifying to define the TTML syntactical equivalent of an event list and a character list.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
@nigelmegitt nigelmegitt mentioned this pull request Sep 16, 2022
Open
nigelmegitt
nigelmegitt reviewed Sep 22, 2022
View reviewed changes
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
nigelmegitt
nigelmegitt reviewed Sep 22, 2022
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In progress review comments

index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@nigelmegitt nigelmegitt mentioned this pull request Sep 23, 2022
Closed
nigelmegitt
nigelmegitt reviewed Sep 23, 2022
View reviewed changes
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
@nigelmegitt nigelmegitt mentioned this pull request Sep 23, 2022
Closed
nigelmegitt
nigelmegitt reviewed Sep 23, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
@nigelmegitt nigelmegitt mentioned this pull request Sep 23, 2022
Closed
3 tasks
nigelmegitt
nigelmegitt approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we can make further changes in smaller, easier to understand, batches.

@cconcolato cconcolato merged commit 94972e9 into main Sep 23, 2022
@nigelmegitt nigelmegitt mentioned this pull request Nov 29, 2022
Closed
@cconcolato cconcolato deleted the merge_model_structure branch December 2, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cconcolato @nigelmegitt