-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Edits to section 7 in response to https://lists.w3.org/Archives/Publi…
- Loading branch information
1 parent
71caba4
commit 9e3c9c4
Showing
1 changed file
with
19 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e3c9c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"While the SELECT queries can be used to identify all focus nodes for a given shape, SHACL processors sometimes also need to find all shapes for which a given node needs to be validated against."
Not at all clear what this means. Please give a fuller explanation, then we can try to work out the wording.
9e3c9c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"All parameters of target types must have at most one value for the same subject."
-> Parameters of target types [what's a "target type"?] must have no more than one value per subject.
[is it clear what "subject" refers to here?]
9e3c9c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The class
sh:TargetType
can be used to declare high-level vocabularies for targets."What's a "high level vocabulary"? Aren't these classes for targets?
9e3c9c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On your first comment: This is meant to say that the operation needs to be applied in the inverse direction. Sometimes you have the shape as a starting point and need to find the focus nodes for it, but other times you have a focus node and need to find the shapes that it is targeted by.
On your second comment, I have switched to the following, hoping it's clearer:
"The parameter values of such targets must not be blank nodes, and the same target must have no more than one value per parameter."
On high-level vocabulary, we have used that term many more times in the document. If we want to get rid of it, we'd need to do it everywhere. The intention is to explain that users don't need to write SPARQL but are provided with a higher-level vocabulary. Maybe such a sentence in the beginning would define it?