Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Security and Privacy Self-Review Questionnaire #126

Merged
merged 10 commits into from
Jan 29, 2024

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Dec 5, 2023

This is a prerequisite for Privacy and Security reviews: https://www.w3.org/Guide/documentreview/#how_to_get_horizontal_review

@rakuco @reillyeon given you're on top of this specification I'm expecting you to help fill in this questionnaire. I pre-populated this doc with some content to help get the work started. I don't claim those responses to be complete or even accurate so I seek your expert review. Thank you for your contributions.

#125 is complementary material to help guide reviewers. I acknowledge that this specification last time reached its CR maturity in 2016 and at that time this self-assessment was not required, and we don't have a prior record. However, we have completed these reviews and done self-assessment for the Generic Sensor family of specs in 2018 which can be reused for its applicable parts for this review. I provided links to those self-assessments in this doc.

security-privacy-self-assessment.md Show resolved Hide resolved
security-privacy-self-assessment.md Outdated Show resolved Hide resolved
security-privacy-self-assessment.md Outdated Show resolved Hide resolved
security-privacy-self-assessment.md Outdated Show resolved Hide resolved
security-privacy-self-assessment.md Outdated Show resolved Hide resolved
anssiko and others added 4 commits December 11, 2023 15:19
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
@anssiko anssiko marked this pull request as ready for review December 11, 2023 13:21
Copy link
Member

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some minor changes.

security-privacy-self-assessment.md Outdated Show resolved Hide resolved
security-privacy-self-assessment.md Outdated Show resolved Hide resolved
security-privacy-self-assessment.md Outdated Show resolved Hide resolved
anssiko and others added 3 commits December 12, 2023 14:24
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
@anssiko
Copy link
Member Author

anssiko commented Dec 12, 2023

Much thanks @reillyeon for your contributions.

This PR welcomes further review and contributions from other interested contributors with an understanding the holiday season is about to start. Thus I'd propose we don't rush this and revisit in January.

@anssiko
Copy link
Member Author

anssiko commented Jan 9, 2024

@rakuco PTAL at your convenience.

@anssiko anssiko mentioned this pull request Jan 22, 2024
27 tasks
@anssiko
Copy link
Member Author

anssiko commented Jan 24, 2024

@lknik @maryammjd @toreini we acknowledge your deep domain expertise could help further improve this self-assessment response before we ship it to the Privacy Interest Group for review. You are of course welcome to provide your feedback also through the PING review mechanism. Thank you for your contributions that enable the WG to deliver privacy-preserving Web APIs.

@lknik
Copy link

lknik commented Jan 24, 2024

Update 2.11 in Security and Privacy Self-Review Questionnaire

@anssiko

Looks good to me. I'd just wonder about "Minor manufacturing imperfections and differences unique to the underlying platform and the sensor hardware in the hosting device can be detected through readings over time."

Is it really possible with reduced precision? Perhaps change from "can be" to "might be"?

@anssiko
Copy link
Member Author

anssiko commented Jan 24, 2024

Perhaps change from "can be" to "might be"?

@lknik thanks, that is a better wording for this. Updated the PR in f9c6e3a

@toreini
Copy link

toreini commented Jan 24, 2024

Hi Anssi,
I read through the document. It generally looks fine to me. One item that I think could be mentioned is the communication channel in 2.3. As it contains PII data a mention of that could help, something like -> a secure communication channel is recommended.

If you think it is too obvious to mention, leave it though.

Cheers,
Ehsan

@anssiko
Copy link
Member Author

anssiko commented Jan 24, 2024

@toreini thanks for your feedback. Your suggestion has been incorporated. I reworded it slightly, see 50ab599

See also https://www.w3.org/TR/security-privacy-questionnaire/#secure-contexts

@toreini
Copy link

toreini commented Jan 24, 2024

Thanks @anssiko ! Yes, I know this exists, but thought it would clarify better if reiterated in the questionnaire. :)

@anssiko
Copy link
Member Author

anssiko commented Jan 29, 2024

With review from multiple WG participants, including the WG's privacy domain experts (thanks @lknik @toreini!), I consider this PR is ready to be merged.

I expect us to continue refine this doc based on review feedback from TAG, PING and Security reviewers. Further contributions are welcome via new PRs.

@anssiko anssiko merged commit c87f8a6 into main Jan 29, 2024
2 checks passed
@anssiko anssiko deleted the sec-priv-questionnaire branch January 29, 2024 12:17
github-actions bot added a commit that referenced this pull request Jan 29, 2024
SHA: c87f8a6
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rakuco added a commit that referenced this pull request Jan 30, 2024
Follow-up to #126.

Rewrite the answer to question 2.13, "How does this specification
distinguish between behavior in first-party and third-party contexts?" by
mentioning that the integration with the Permissions Policy specification
does cause this spec to distinguish between first-party and third-party
context.
Copy link
Member

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the late review.

Question 2.13, the one about different behavior in first-party and third-party contexts, did get me thinking, so I've filed #135 to mention that the Permissions Policy integration affects third-party contexts. I've also filed #133 to track a mismatch between the current S&P normative requirements and the Permissions Policy integration we have.

rakuco added a commit that referenced this pull request Jan 31, 2024
…ion (#135)

Follow-up to #126.

Rewrite the answer to question 2.13, "How does this specification
distinguish between behavior in first-party and third-party contexts?" by
mentioning that the integration with the Permissions Policy specification
does cause this spec to distinguish between first-party and third-party
context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants