Replace same-origin Security & Privacy requirement with Permissions Policy one #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olicy one This addresses a conflict that was introduced in #121: - The presence of the Permissions Policy integration means usage of the Device Orientation API can be allowed in third-party iframes provided that the right tokens are in place. - The "Security and privacy considerations" section contains a requirement that events are fired only on child navigables that are same-origin with the top-level traversable. The latter was introduced in #25 and served as a stop-gap measure before Permissions Policy integration was added. The current implementation status is: - Blink never implemented the same-origin requirement, but added Permissions Policy integration in 2018. - WebKit has always implemented Permissions Policy integration. - Gecko implements the same-origin requirement (see Mozilla bug 1197901). This means we can safely replace the same-origin requirement with a requirement to support the Permissions Policy integration, as switching from one to the other is transparent in the sense that the exact same set of websites that worked before will continue to work with the change, as the features we define have a default allowlist of "self". Fixes #133
reillyeon
approved these changes
Jan 31, 2024
rakuco
deleted the
remove-same-origin-security-and-privacy-requirement
branch
|
Does this suggest changes to https://www.w3.org/TR/orientation-event/#changes If yes, please submit a PR to add one more bullet. |
rakuco
added a commit
that referenced
this pull request
Feb 2, 2024
The language used to describe the previous Security & Privacy is not very precise, but using the right terms would make the sentence long and harder to understand.
Done in #138 |
anssiko
pushed a commit
that referenced
this pull request
Feb 2, 2024
The language used to describe the previous Security & Privacy is not very precise, but using the right terms would make the sentence long and harder to understand.
github-actions bot
added a commit
that referenced
this pull request
Feb 2, 2024
SHA: 36b567e Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a conflict that was introduced in #121:
Device Orientation API can be allowed in third-party iframes provided that
the right tokens are in place.
that events are fired only on child navigables that are same-origin with
the top-level traversable.
The latter was introduced in #25 and served as a stop-gap measure before
Permissions Policy integration was added.
The current implementation status is:
Policy integration in 2018.
This means we can safely replace the same-origin requirement with a
requirement to support the Permissions Policy integration, as switching from
one to the other is transparent in the sense that the exact same set of
websites that worked before will continue to work with the change, as the
features we define have a default allowlist of "self".
Fixes #133
Preview | Diff