Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: Identify at risk features and their causes #149

Merged
merged 1 commit into from Mar 22, 2024
Merged

Conversation

reillyeon
Copy link
Member

@reillyeon reillyeon commented Mar 13, 2024

@reillyeon
Copy link
Member Author

@anssiko and @marcoscaceres, please take a look.

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reillyeon this looks good to me, thanks!

@himorin can we keep these inline or do we need to pull them up to SOTD to pass checkers etc.? I personally feel keeping these inline is better to retain context.

@himorin
Copy link
Contributor

himorin commented Mar 14, 2024

I believe both (having or not having in SoTD) should be fine. One example for not having.
at-risk is MAY in process, and no strict text is provided in pubrules.

@reillyeon
Copy link
Member Author

@marcoscaceres, can you take a look?

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. Thanks!

@reillyeon reillyeon merged commit 2cdab15 into main Mar 22, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Mar 22, 2024
SHA: 2cdab15
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@marcoscaceres marcoscaceres deleted the at_risk branch April 15, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants