Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: rewrite permissions section #165

Merged
merged 5 commits into from
May 8, 2024
Merged

Editorial: rewrite permissions section #165

merged 5 commits into from
May 8, 2024

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented May 2, 2024

The permission sections was confusing features and permissions.

APIs can be classified into powerful features, but only the permissions matter.


Preview | Diff

@himorin
Copy link
Contributor

himorin commented May 2, 2024

needs to update hash at

* implement [[#permissions-policy-integration]] so that events are fired on [=child navigables=] (including but not restricted to cross-origin ones) only if allowed by the [=/top-level traversable=],
also

The permission sections was confusing features and permissions.

APIs can be classified into powerful features, but only the permissions matter.
@marcoscaceres
Copy link
Member Author

Rebased...

Copy link
Member

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combining these sections makes sense. My comments are mostly grammar/typographical nits.

index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
marcoscaceres and others added 3 commits May 7, 2024 14:56
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
@marcoscaceres marcoscaceres merged commit 0791720 into main May 8, 2024
2 checks passed
@marcoscaceres marcoscaceres deleted the permissions branch May 8, 2024 00:02
github-actions bot added a commit that referenced this pull request May 8, 2024
SHA: 0791720
Reason: push, by marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants