Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata properties don't define data model and serialization format #499

Closed
msporny opened this issue Dec 14, 2020 · 3 comments
Closed
Assignees
Labels
pr exists There is an open PR to address this issue

Comments

@msporny
Copy link
Member

msporny commented Dec 14, 2020

The current metadata properties in the specification don't define data model and serialization formats for all metadata properties. This should be fairly straightforward to fix by defining this sort of stuff in the definitions for each metadata property.

@peacekeeper
Copy link
Contributor

Section "Metadata Structure" says:

The structure used to communicate this metadata MUST be a map of properties. Each property name MUST be a string. Each property value MUST be a string, map, list, boolean, or null. The values within any complex data structures such as maps and lists MUST be one of these data types as well.

I think you're correct that some metadata properties such as created define the data type of their value, whereas this is currently missing for others such as accept.

@msporny msporny added pr exists There is an open PR to address this issue and removed ready for pr Issue is ready for a PR labels Dec 27, 2020
@msporny
Copy link
Member Author

msporny commented Dec 27, 2020

PR #516 addresses this issue. This issue will be closed when PR #516 is merged.

@msporny
Copy link
Member Author

msporny commented Jan 3, 2021

PR #516 has been merged, closing.

@msporny msporny closed this as completed Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr exists There is an open PR to address this issue
Projects
None yet
Development

No branches or pull requests

2 participants