Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the serviceEndpoint property to allow for a string or array of strings #506

Closed
csuwildcat opened this issue Dec 15, 2020 · 2 comments
Closed

Correct the serviceEndpoint property to allow for a string or array of strings #506

csuwildcat opened this issue Dec 15, 2020 · 2 comments
Assignees
@msporny
Labels
pr exists There is an open PR to address this issue

Comments

@csuwildcat
Copy link
Contributor

The current text in the spec says that the serviceEndpoint property in Service Endpoint entries must be either a string or an object. Apparently this is not what it should have been (per @msporny), so it should be corrected to allow an array.

See this earlier Issue for history on this: #359
@msporny msporny self-assigned this Dec 20, 2020
@msporny msporny added pre-cr-p1 ready for pr Issue is ready for a PR labels Dec 20, 2020
msporny added a commit that referenced this issue Dec 20, 2020
@msporny
Allow serviceEndpoint to be an array. Address #506.
a8c2a43
@msporny msporny mentioned this issue Dec 20, 2020
Merged
@msporny
Copy link
Member

msporny commented Dec 20, 2020 •
edited
Loading

@csuwildcat I've created PR #510 to address this issue. Please review.

This issue will be closed once PR #510 has been merged.

@msporny msporny added pr exists There is an open PR to address this issue and removed ready for pr Issue is ready for a PR labels Dec 20, 2020
@agropper agropper mentioned this issue Dec 21, 2020
Closed
msporny added a commit that referenced this issue Dec 27, 2020
@msporny
Allow serviceEndpoint to be an array. Address #506.
b75b9fa
@msporny
Copy link
Member

msporny commented Dec 27, 2020

PR #510 has been merged. Closing.

@msporny msporny closed this as completed Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
pr exists There is an open PR to address this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msporny @csuwildcat