Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proving Control sections are wrong #583

Closed
rhiaro opened this issue Jan 28, 2021 · 9 comments
Closed

Proving Control sections are wrong #583

rhiaro opened this issue Jan 28, 2021 · 9 comments
Assignees
Labels
editorial Editors should update the spec then close

Comments

@rhiaro
Copy link
Member

rhiaro commented Jan 28, 2021

The proving control of DID docs and of public keys subsections in Security Considerations are inaccurate.

We need to fix these ASAP, but this can probably be done during CR as they are not normative.

@msporny
Copy link
Member

msporny commented Jan 28, 2021

Yes, correct. These sections were written long ago and are now misleading at best and catastrophically wrong at worst. @jandrieu and @talltree -- both of you may want to take a look.

@msporny
Copy link
Member

msporny commented Feb 1, 2021

PR #588 has been raised to mark the sections as wrong. We still need a PR to fix this issue.

@msporny msporny added editorial Editors should update the spec then close and removed pre-cr-p3 labels Feb 25, 2021
@peacekeeper
Copy link
Contributor

I agree the sections could be improved. They talk too much about signed DID documents.

But there is also some useful content in there that shouldn't be removed. E.g. to state that 1. a signed DID document doesn't prove control of a DID, and 2. proving control of a DID requires DID resolution, those are two important points to mention.

@ktobich
Copy link

ktobich commented Mar 19, 2021

Paragraph 9.2.2 Proving Control of a Public Key might need to reviewed by getting inspirited by the Static Data Authentication (SDA) and the Dynamic Data Authentication (DDA) used in the payment industry and highlight maybe the differences with static and dynamic method used by the DID and described in the section. The ICAO (passport) scheme might be a good one too.

@iherman
Copy link
Member

iherman commented Mar 31, 2021

The issue was discussed in a meeting on 2021-03-30

  • no resolutions were taken
View the transcript

5.5. Proving Control sections are wrong

See github issue #583.

Brent Zundel: Assigned to Amy, but I don't see her. manu or markus_sabadello?

Manu Sporny: Amy is going to do it

@iherman
Copy link
Member

iherman commented May 4, 2021

The issue was discussed in a meeting on 2021-05-04

  • no resolutions were taken
View the transcript

7.1. Proving Control sections are wrong

See github issue #583.

Brent Zundel: There has been a bit of conversation. Need a PR to fix issue.

Manu Sporny: General statement: I triaged issue this past weekend, marked everything that was a CR comment. Marked anything ready for a PR as ready for PR.
… Almost every one except 2 or 3 are ready for PR.

Amy Guy: brent, I'm looking at 583 but I think I'll need help. Will ping people.

Brent Zundel: If you haven't and always wanted to write a PR for a specification, we have a number of issues to choose from, and I encourage you to do so.

@msporny
Copy link
Member

msporny commented May 16, 2021

PR #738 has been created to address this issue. This issue will be closed once that PR has been merged.

@msporny msporny added pr exists There is an open PR to address this issue and removed ready for pr Issue is ready for a PR labels May 16, 2021
@msporny
Copy link
Member

msporny commented May 25, 2021

PR #738 has been merged.

@rhiaro please confirm that the PR addressed your concern; if so, mark the issue as cr-comment-resolved-explicit, and then close the issue.

@iherman
Copy link
Member

iherman commented May 26, 2021

The issue was discussed in a meeting on 2021-05-25

  • no resolutions were taken
View the transcript

3.7. Proving Control sections are wrong

See github issue #583.

Manu Sporny: The PR is in and has been merged, and I am waiting for Amy to see if it addressed her concern

Brent Zundel: There are currently 15 open PRs that are all editorial
… I encourage WG members to go in and review and approve (or improve)
… the editors rely on our review to know when they can go forward with a merge
… thank you everyone for your hard work; it is a pleasure to work with you
… NO SPECIAL TOPIC CALL this week
… next meeting is June 1


@rhiaro rhiaro added cr-comment-resolved-explicit and removed pr exists There is an open PR to address this issue labels May 26, 2021
@rhiaro rhiaro closed this as completed May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editors should update the spec then close
Projects
None yet
Development

No branches or pull requests

5 participants