Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example 1 in spec is perhaps not "minimal", as its caption suggests #723

Closed
ssstolk opened this issue Apr 23, 2021 · 2 comments
Closed

Example 1 in spec is perhaps not "minimal", as its caption suggests #723

ssstolk opened this issue Apr 23, 2021 · 2 comments
Assignees
Labels
cr-comment Candidate Recommendation comment cr-comment-resolved-explicit Candidate Recommendation comment resolved with explicit agreement Editorial Editors should update the spec then close

Comments

@ssstolk
Copy link

ssstolk commented Apr 23, 2021

Currently, the caption of example 1 is "A minimal DID document".
Given the only core property that is mandatory is "id", the example in 1 is small but perhaps not minimal.
In order to avoid suggesting the "authentication" property is mandatory in the example, I would suggest rephrasing the caption to smth along the lines of "A concise DID document"?
(Of course, this is from the point of me, as non-native English speaker, as to the meaning of 'minimal' being the smallest possible.)

@iherman iherman added the Editorial Editors should update the spec then close label Apr 23, 2021
@msporny msporny self-assigned this Apr 25, 2021
msporny added a commit that referenced this issue Apr 25, 2021
@msporny
Copy link
Member

msporny commented Apr 25, 2021

PR #725 has been raised to address your concern, @ssstolk.

Do the changes in that PR address your concern?

@msporny msporny added the cr-comment Candidate Recommendation comment label Apr 25, 2021
msporny added a commit that referenced this issue Apr 30, 2021
@msporny msporny added the cr-comment-resolved-explicit Candidate Recommendation comment resolved with explicit agreement label Apr 30, 2021
@msporny
Copy link
Member

msporny commented Apr 30, 2021

Note that @ssstolk has confirmed that this change works for them. Closing.

@msporny msporny closed this as completed Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cr-comment Candidate Recommendation comment cr-comment-resolved-explicit Candidate Recommendation comment resolved with explicit agreement Editorial Editors should update the spec then close
Projects
None yet
Development

No branches or pull requests

3 participants