Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove closed issues from the list #237

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Conversation

rhiaro
Copy link
Member

@rhiaro rhiaro commented Mar 23, 2020

Very minor editorial update to the issues list at the end of the document


Preview | Diff

@rhiaro rhiaro added the editorial Editors should update the spec then close label Mar 23, 2020
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than merging this PR, I think ReSpec has magic that automatically generates the open issues list - we should use that (if it works).

@rhiaro
Copy link
Member Author

rhiaro commented Mar 23, 2020

Hmm okay, will investigate

@rhiaro
Copy link
Member Author

rhiaro commented Mar 23, 2020

Okay I found that and it generates a list of issues which are referenced in the spec, but not a complete list of all open issues. It also duplicates listings of issues that are referenced more than once (eg. #204). I can push the change if that's better, but not sure if it is.

Looks like this currently:

Screenshot at 2020-03-23 15-17-08

@msporny
Copy link
Member

msporny commented Mar 23, 2020

I can push the change if that's better, but not sure if it is.

You're right, that's not better... I have a script that I run that pulls all of the open issues and dumps them into the spec. Busy right now, can't find it, will find it later.

Let's merge this PR.

@msporny
Copy link
Member

msporny commented Mar 23, 2020

Editorial, merging.

@msporny msporny merged commit fa76b59 into master Mar 23, 2020
@msporny msporny deleted the rhiaro-remove-closed-issues branch March 23, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editors should update the spec then close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants