Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advisement on computing the cryptographic hash of a context #485

Merged
merged 4 commits into from Dec 20, 2020

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Dec 12, 2020

Addresses #464


Preview | Diff

@OR13
Copy link
Contributor Author

OR13 commented Dec 12, 2020

Personally, I think it might be better to remove the language regarding computing hashes of contexts, but if it remains, it must be defined in sufficient detail to be useful.

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM... minor corrections to tag nesting (p and pre are block level HTML elements and can't be put inside each other)... removed fragment as there is no normative spec that states how to integrity check URLs -- could use Hashlink here? Or IPFS? None of it could be normative, though.

index.html Outdated Show resolved Hide resolved
index.html Outdated
Comment on lines 2759 to 2763
If included, the cryptographic hash of the content of the JSON-LD Context, MUST be computed in a manner equivalent to:
<pre class="example">
curl -s https://www.w3.org/ns/did/v1#910cd6648f6f7b72a7896a8da83e63460eb8355a0af4b56b699c9281452ac8bb | openssl sha256
</pre>
The integrity check is considered valid if and only if the hex digest of the resource matches the fragment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular line isn't needed is it? We're not telling people how to write their software... just how to register their contexts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is necessary to explain how they can register their contexts.

an alternative would be to tell them to register the URL and integrity digest separately.... which seems like a missed opportunity for making things easy, for both humans and computers.

@msporny
Copy link
Member

msporny commented Dec 13, 2020

Personally, I think it might be better to remove the language regarding computing hashes of contexts, but if it remains, it must be defined in sufficient detail to be useful.

Yeah, the more I think about it, the more I think it would be better to remove the context hashes until we can point to a spec that can refer to them in a way that is normative (with normative processing rules). Hashlink could do that, but it's years away from being a standard.

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
OR13 and others added 2 commits December 17, 2020 08:24
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: David I. Lehn <dlehn@digitalbazaar.com>
@msporny msporny merged commit c931711 into main Dec 20, 2020
@msporny
Copy link
Member

msporny commented Dec 20, 2020

Normative, multiple reviews, changes requested and made, no objections, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants