Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing example with verification method in a service #565

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Removing example with verification method in a service #565

merged 2 commits into from
Jan 28, 2021

Conversation

iherman
Copy link
Member

@iherman iherman commented Jan 20, 2021 •
edited by pr-preview bot
Loading

This is the alternative to #554 : removing the example of a service with a verification method.

This is also relevant to #404.

Preview | Diff

@iherman iherman mentioned this pull request Jan 20, 2021
Closed
@iherman
Copy link
Member Author

iherman commented Jan 27, 2021

@rhiaro is there an easy way of solving this merge conflict without being forced to rebase my version to main (which has changed a lot...)? It would be simpler, actually, to create a new PR with that tiny change on main and merge that right away...

(no, I am not a github expert...)

cc @msporny

@iherman
Copy link
Member Author

iherman commented Jan 28, 2021

@msporny @rhiaro I have taken care of the merge conflicts. This should now be merged ASAP to avoid new conflicts to appear...

@msporny msporny merged commit da61862 into main Jan 28, 2021
@msporny
Copy link
Member

msporny commented Jan 28, 2021

Editorial, multiple reviews, changes requested and made (in another PR, implemented in this PR), no objections, merging.

@msporny msporny deleted the remove-verification-method-in-service-example branch February 21, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny msporny approved these changes

@peacekeeper peacekeeper peacekeeper approved these changes

@rhiaro rhiaro rhiaro approved these changes

@brentzundel brentzundel brentzundel approved these changes

@kdenhartog kdenhartog kdenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iherman @msporny @peacekeeper @rhiaro @brentzundel @kdenhartog