Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

at risk: mark alsoKnownAs at risk, for #584 #589

Merged
merged 1 commit into from Feb 8, 2021
Merged

at risk: mark alsoKnownAs at risk, for #584 #589

merged 1 commit into from Feb 8, 2021

Conversation

rhiaro
Copy link
Member

@rhiaro rhiaro commented Feb 1, 2021 •
edited by pr-preview bot

@rhiaro rhiaro requested a review from msporny February 1, 2021 16:35
msporny
msporny approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@msporny msporny left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, especially since this seems to fall into the category of things the group didn't want to put in DID Core. Paging @jandrieu and @talltree.

@msporny msporny mentioned this pull request Feb 1, 2021
Closed
@msporny
Copy link
Member

msporny commented Feb 8, 2021

Editorial, multiple positive reviews, no objections, merging.

@msporny msporny merged commit e5cf7f3 into main Feb 8, 2021
@msporny msporny deleted the rhiaro-584 branch February 21, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny msporny approved these changes

@brentzundel brentzundel brentzundel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rhiaro @msporny @brentzundel