Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to use cases document. Consolidate other useful links. #774

Merged
merged 5 commits into from Jul 17, 2021

Conversation

msporny
Copy link
Member

@msporny msporny commented Jul 10, 2021

I did it guys!
I'm not completely inept. :P
...after 5 long years, the DID specification finally links to its use cases document.


Preview | Diff

@msporny msporny added cr-comment Candidate Recommendation comment Editorial Editors should update the spec then close labels Jul 11, 2021
Copy link
Contributor

@philarcher philarcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for doing this @msporny, much appreciated. However, I'm going to be annoying and push for just a little more and, in doing so, hope to fix a small problem.

I suggest that the 4th paragraph of the introduction to the doc could be extended by a short sentence so that we have "... all without depending on a central authority to guarantee the continued existence of the identifier. These ideas are explored in the DID Use Cases document [[DID-USE-CASES]]."

This a) puts a link in the informative text rather then relying solely on the references section; b) uses SpecRef's database to insert the reference rather than the hand-edited link in the ReSpec config which, although it points to the correct URL, it uses author data from the CCG original.

@msporny
Copy link
Member Author

msporny commented Jul 12, 2021

Thanks very much for doing this @msporny, much appreciated. However, I'm going to be annoying and push for just a little more and, in doing so, hope to fix a small problem.

I suggest that the 4th paragraph of the introduction to the doc could be extended by a short sentence so that we have "... all without depending on a central authority to guarantee the continued existence of the identifier. These ideas are explored in the DID Use Cases document [[DID-USE-CASES]]."

This a) puts a link in the informative text rather then relying solely on the references section;

We already have a link in the informative text, that's what this PR does:

https://github.com/w3c/did-core/pull/774/files#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051R433-R437

I added your text as well, let me know if that's what you were going for?

b) uses SpecRef's database to insert the reference rather than the hand-edited link in the ReSpec config which, although it points to the correct URL, it uses author data from the CCG original.

Ah, yes, thank you and fixed in b6e0136.

@msporny msporny requested a review from philarcher July 12, 2021 14:00
Copy link
Contributor

@philarcher philarcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted, thank you.

@msporny msporny merged commit 1e443bc into main Jul 17, 2021
@msporny
Copy link
Member Author

msporny commented Jul 17, 2021

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny deleted the msporny-issue-766 branch July 17, 2021 17:43
@msporny msporny added the cr-comment-resolved-explicit Candidate Recommendation comment resolved with explicit agreement label Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cr-comment Candidate Recommendation comment cr-comment-resolved-explicit Candidate Recommendation comment resolved with explicit agreement Editorial Editors should update the spec then close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants