Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context links for the signature suites #310

Closed
kdenhartog opened this issue Jun 2, 2021 · 4 comments · Fixed by #346
Closed

Update context links for the signature suites #310

kdenhartog opened this issue Jun 2, 2021 · 4 comments · Fixed by #346
Assignees

Comments

@kdenhartog
Copy link
Member

I noticed some of the signature suites still point at the did-core context rather than the split out ones. This is an issue to track those and get them updated.

@kdenhartog kdenhartog self-assigned this Jun 2, 2021
@OR13
Copy link
Contributor

OR13 commented Oct 19, 2021

We have addressed this issue, it should be closed, and its not actionable.

@OR13
Copy link
Contributor

OR13 commented Oct 19, 2021

@OR13 OR13 closed this as completed Oct 19, 2021
@iherman
Copy link
Member

iherman commented Oct 19, 2021

The issue was discussed in a meeting on 2021-10-19

  • no resolutions were taken
View the transcript

5.1. Update context links for the signature suites (issue did-spec-registries#310)

See github issue did-spec-registries#310.

Michael Prorock: +1 close

Orie Steele: this one is stale, seems closeable

Daniel Burnett: sidebar: fine to proceed a little faster with an "any objections?"

Manu Sporny: a link to a PR that closed this issue would be nice

Manu Sporny: +1 to close.

@kdenhartog
Copy link
Member Author

kdenhartog commented Oct 19, 2021

Uh not sure what you mean? the context link points at this:
https://www.w3.org/ns/did/v1

not this: http://w3id.org/security/suites/jws-2020/v1

All of the signature suites that point at the did-core context are incorrect now that the did-core context doesn't include suites so anyone relying on the did-core context to get their suite definitions will be inadvertently dropping public keys in their did documents when using the JSON-LD representation. I think this should remain open until that's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants