Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to refactor fixtures for implementers #32

Closed
OR13 opened this issue Feb 25, 2021 · 6 comments
Closed

We need to refactor fixtures for implementers #32

OR13 opened this issue Feb 25, 2021 · 6 comments
Assignees

Comments

@OR13
Copy link
Contributor

OR13 commented Feb 25, 2021

We need to clearly show the difference between abstract and concrete representations.

there should be did document data models for both abstract and concrete examples

@msporny msporny changed the title We need to refactor fixtures for vendors We need to refactor fixtures for implementers Feb 25, 2021
@OR13
Copy link
Contributor Author

OR13 commented Feb 25, 2021

I am asserting that no PRs will make it in until we have at least one example of an implementer fixture that shows how to do this... and its going to be dangerous to skip over it.

@msporny msporny self-assigned this Mar 30, 2021
@iherman
Copy link
Member

iherman commented Mar 31, 2021

The issue was discussed in a meeting on 2021-03-30

  • no resolutions were taken
View the transcript

7.3. We need to refactor fixtures for implementers

See github issue did-test-suite#32.

Orie Steele: Same point Markus and others have raised. Essentially, the structure of the test suites is not set in stone or finalized or working.
… This issue is raised at a time of great frustration, but since then we have got many more people contributing to this.
… I don't think we have finished refactoring the test fixtures, as evidenced by Markus's comments, but I think we are on our way.

Brent Zundel: This one is unassigned

Manu Sporny: I will take it
… Critical path... I don't want to put myself in the critical path... I will make an attempt.
… There is an order of operations here. One is we figure out details of testing all this stuff. Once we figure it out, it will be a bit of a mess
… We will need to refactor it. Then we expect the DID method implementers to come in and fill it out.
… Concerned about order of operations...
… If anyone gets to it before I do, please take a shot at it.

Markus Sabadello: Please review my PR about DID Resolution tests.. #43

@msporny
Copy link
Member

msporny commented Apr 3, 2021

I have raised PR #52 to address this issue. Specifically, there is now an implementations directory that implementers can look at and submit their own implementations for.

@iherman
Copy link
Member

iherman commented Apr 6, 2021

The issue was discussed in a meeting on 2021-04-06

  • no resolutions were taken
View the transcript

7.7. need clear instructions for implementers

See github issue did-test-suite#33, did-test-suite#32.

Markus Sabadello: also related to refactoring
… implementers of a did method or the spec in another way so they know how exactly they submit their data

Daniel Burnett: pretty straightforward

Markus Sabadello: last two are about sections of the spec which are still missing
… there are not tests yet

@msporny
Copy link
Member

msporny commented Apr 10, 2021

This is done once PR #55 is merged.

@msporny
Copy link
Member

msporny commented Apr 18, 2021

PR #55 has been merged, closing.

@msporny msporny closed this as completed Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants