DID Metadata Structure Test (first set) #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
reviewed
Apr 1, 2021
| @@ -0,0 +1,61 @@ | |||
| const didMetadataStructureTest_r = (didDocumentMetadata) => { | |||
| describe("didDocumentMetadata", () => { | |||
There was a problem hiding this comment.
if you can prefix this with the section of the spec that will help us make sure we are covering everything
There was a problem hiding this comment.
It's a function called from main describe section. For the source-code-wise, prefix might be useful, but if we ran test verbosely, the section number appears multiple times. May let me consider what is the best solution in future commits.
OR13
reviewed
Apr 1, 2021
| }; | ||
|
|
||
| const didMetadataStructureTests = (suiteConfig) => { | ||
| describe('7.3 Metadata Structure', () => { |
OR13
approved these changes
Apr 1, 2021
OR13
reviewed
Apr 1, 2021
|
|
||
| it('Each property value MUST be a string, map, list, ordered set, boolean, or null.', () => { | ||
| Object.keys(didDocumentMetadata).forEach((property_name) => { | ||
| expect(typeof didDocumentMetadata[property_name]).toEqual(expect.stringMatching(/(string|object|boolean)/)); // map, list, set and null are objects |
There was a problem hiding this comment.
a bit of a nit, but potentially we can test "list / set" better
There was a problem hiding this comment.
Any suggestion welcome. I think we need to have some is-a functions for all of the basic types and consistently use it.
clehner
approved these changes
Apr 1, 2021
peacekeeper
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains on-going work for Metadata Structure tests, Issue #31.
Includes most of the tests besides one with dependency with spec registry.