-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ambiguity in DPUB-AAM for listitem children(?) of doc-bibliography and doc-endnotes #34
Comments
Well shoot... I filed this on DPUB-ARIA not DPUB-AAM. Thanks if you can move it. |
The problem that led to doc-biblioentry and doc-endnote being deprecated in 1.1 is that doc-bibliography and doc-endnotes are not list roles, so you'd use them on a This rule, as I recall, is trying to imply the doc-biblioentry and doc-endnote roles on the immediate children of top-most list within its respective section, without capturing lists within the bibliography entry or endnote. For example:
|
@mattgarrish wrote:
Okay then I think the spec should consider this pseudo diff, which would be more precise and unblock the related tests. - listitem descendants of [accessibility parent role name] (not descendant of another listitem)
+ listitem children of [accessibility parent role name] |
Actually the first child |
Right, the implied roles are always children of a If you wanted to include the list, and have them identified as children, it would have to be more like:
The parent role is |
I'm curious, though, should we even have these mappings that imply deprecated roles? Doesn't it mean that any user agent that implements the mapping will add the deprecated roles to the list items, overriding the correct authoring that excludes the roles? Similarly, if you use the list/listitem roles instead of ul/li in a bibliography or endnotes section, will it also override the listitem role? It seems like it makes the situation worse than it is now, or am I misunderstanding something? |
Yikes... I didn't know they were deprecated. Good catch. I will pull those out of the WPT Pull Request, and yes, I think those should be removed (or marked as deprecated in DPUB-AAM) |
We didn't have these mappings in 1.0, so we should be able to remove them entirely. I've been trying to figure out what issue they were supposed to solve so we don't create a new problem by removing them, but so far have had no luck. It looks like whatever discussion we had was in a meeting or by email as I can't track anything down. I think the idea was that these implied roles would provide a means of identifying the entries if a user agent or processor wanted to do something with them. That could probably be done as notes for each role in the dpub-aria spec, rather than having the implied purpose turn into real roles as these mappings make happen. @aleventhal @joanmarie @avneeshsingh @TzviyaSiegman do any of you have any better recollections, or any comments on removing these mappings and using notes instead? (Or just dropping the mappings and doing nothing else.) |
The following DPUB-AAM mappings:
…both use the prose:
Which I think is intended to mean children:
(where "accessibility children" is the ARIA definition...)
But perhaps there is some other reason for the additional complexity? For example, as phrased, it also pulls in the following, which I think is unintentional.
In any case, I blocked the WPT
computedrole
tests for those two until the working group resolves the ambiguity.Editorial Note: there are also some typos in these same headings:
ofanother
in #role-map-biblioentry-impliedanother<code>listitem</code>
in #role-map-endnote-implied (missing space afteranother
)The text was updated successfully, but these errors were encountered: