Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranges for dcat:bbox and dcat:centroid #1359

Closed
riccardoAlbertoni opened this issue Apr 30, 2021 · 11 comments · Fixed by #1360
Closed

Ranges for dcat:bbox and dcat:centroid #1359

riccardoAlbertoni opened this issue Apr 30, 2021 · 11 comments · Fixed by #1360
Labels
dcat due for closing Issue that is going to be closed if there are no objection within 6 days feedback Issues stemming from external feedback to the WG
Milestone

Comments

@riccardoAlbertoni
Copy link
Contributor

Range changed from rdfs:Literal to locn:Geometry via #1303. The corrections will appear in the next PWD.

Thank you.

I guess this should also apply to dcat:bbox and dcat:centroid.

Originally posted by @init-dcat-ap-de in #1293 (comment)

@riccardoAlbertoni riccardoAlbertoni added dcat ErratumRaised Raised to become an Errata later labels Apr 30, 2021
@riccardoAlbertoni riccardoAlbertoni added this to To do in DCAT revision via automation Apr 30, 2021
@riccardoAlbertoni riccardoAlbertoni added this to the DCAT3 3PWD milestone Apr 30, 2021
@andrea-perego andrea-perego added this to To do in DCAT Sprint: Space and Time via automation Apr 30, 2021
@andrea-perego andrea-perego removed this from To do in DCAT revision Apr 30, 2021
@andrea-perego
Copy link
Contributor

@init-dcat-ap-de ,

Properties dcat:bbox and dcat:centroid are meant to be used only with literals, and are therefore also explicitly defined as owl:DatatypeProperty's.

@andrea-perego andrea-perego added feedback Issues stemming from external feedback to the WG and removed ErratumRaised Raised to become an Errata later labels Apr 30, 2021
@init-dcat-ap-de
Copy link

They have the same range and usage notes as locn:geometry.
But semantic geo data is by no means my area of expertise.

@andrea-perego
Copy link
Contributor

@init-dcat-ap-de said:

They have the same range and usage notes as locn:geometry.

The range and usage note of dcat:bbox and dcat:centroid are indeed still the same, but those of locn:geometry have been modified via PR #1303 , as discussed in #1293

See https://w3c.github.io/dxwg/dcat/#Property:location_geometry

Range: locn:Geometry

Usage note:

The range of this property (locn:Geometry) allows for any type of geometry specification. E.g., the geometry could be encoded by a literal, as WKT (geosparql:wktLiteral [GeoSPARQL]), or represented by a class, as geosparql:Geometry (or any of its subclasses) [GeoSPARQL].

@init-dcat-ap-de
Copy link

@andrea-perego not sure if this is just a missunderstanding. I understood your post from 3 days ago as an argument, why bbox and centroid should remain with a range of rdfs:Literal.

But they have the same usage note as locn:geometry had previously, which stated that the range was "intentionally generic, with the purpose of allowing different geometry encodings."

The reason to switch the range to locn:Geometry was: locn:Geometry is more generic than rdfs:Literal. The following statements would be valid:

<AnneFrank_3> a dcat:Dataset ;
  dcterms:spatial [
    a dcterms:Location ;
    dcat:centroid <http://geohash.org/u173znse00r> ;
  ] .

So we should either change their range to locn:Geometry or change the usage notes so that they say that one is exspected to use a WKT literal.

@andrea-perego
Copy link
Contributor

@init-dcat-ap-de said:

@andrea-perego not sure if this is just a missunderstanding. I understood your post from 3 days ago as an argument, why bbox and centroid should remain with a range of rdfs:Literal.

But they have the same usage note as locn:geometry had previously, which stated that the range was "intentionally generic, with the purpose of allowing different geometry encodings."

Exactly. The original usage note for the three properties was referring to rdfs:Literal as range, and therefore we have not seen the need of changing it for dcat:bbox and dcat:centroid.

Based on what you say, it seems that the note is not clear enough about the fact that dcat:bbox and dcat:centroid are supposed to be used only with literals:

The range of this property is intentionally generic, with the purpose of allowing different geometry encodings. E.g., the geometry could be encoded as WKT (geosparql:wktLiteral [GeoSPARQL]).

Note that here with "generic" we mean that, by specifying rdfs:Literal as range, we are not prescribing any specific datatype (e.g., geosparql:wktLiteral, geosparql:gmlLiteral, geosparql:geoJSONLiteral).

I wonder whether revising the note as follows may help clarify this point:

The range of this property (rdfs:Literal) is intentionally generic, with the purpose of allowing different geometry literal encodings. E.g., the geometry could be encoded as a WKT literal (geosparql:wktLiteral [GeoSPARQL]).

@init-dcat-ap-de
Copy link

Yes, this would clear things up for me.

andrea-perego added a commit that referenced this issue May 4, 2021
Usage notes of `dcat:bbox` and `dcat:centroid` has been revised as proposed in #1359 (comment) to make it clear that these properties are supposed to be used only with literals.
@andrea-perego
Copy link
Contributor

Yes, this would clear things up for me.

The relevant revision will be dealt with via PR #1360 (yet to be merged).

@dr-shorthair
Copy link
Contributor

Possibly of interest here is that GeoSPARQL is adding geo:hasCentroid and geo:hasBoundingBox properties - specialization of geo:hasGeometry.

The range of hasCentroid is a Point (e.g. sf:Point) and of hasBoundingBox is a box (e.g. sf:Envelope)

@andrea-perego andrea-perego changed the title ranges for dcat:bbox and dcat:centroid. Ranges for dcat:bbox and dcat:centroid May 13, 2021
@chris-little
Copy link

@riccardoAlbertoni @andrea-perego Apologies for commenting from a position of relative ignorance: Can a dcat:bbox encompass both Axis Aligned BBOX, as commonly used in 2D mapping, and Object Oriented BBOX, as commonly used in 3D modelling and 2/3D computer graphics?
I have assumed that a dcat:bbox is not necessarily the unique minimal BBOX for a feature of interest.

@dr-shorthair
Copy link
Contributor

Chris - BBox is conventionally aligned to cartesian axes, and implemented with two coordinates corresponding to the lower and upper vertices of the box - see the GeoSPARQL links above. I think you would surprise people with any more novel interpretation, which would probably be unhelpful for general 'interoperability'.

@andrea-perego andrea-perego linked a pull request May 24, 2021 that will close this issue
@riccardoAlbertoni riccardoAlbertoni added the due for closing Issue that is going to be closed if there are no objection within 6 days label May 24, 2021
@riccardoAlbertoni
Copy link
Contributor Author

It seems this issue is addressed by the merged PR, shall we close it? any objections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dcat due for closing Issue that is going to be closed if there are no objection within 6 days feedback Issues stemming from external feedback to the WG
Development

Successfully merging a pull request may close this issue.

5 participants