Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset series v2 (issue 1272) #1292

Merged
merged 47 commits into from
Mar 23, 2021
Merged

Conversation

riccardoAlbertoni
Copy link
Contributor

@riccardoAlbertoni riccardoAlbertoni commented Feb 9, 2021

Draft including dcat:DatasetSeries as a new class as discussed in #1272.

Diff: https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fw3c.github.io%2Fdxwg%2Fdcat%2F&doc2=https%3A%2F%2Fraw.githack.com%2Fw3c%2Fdxwg%2Fdcat-dataseries-issue1272%2Fdcat%2Findex.html

TODO: (once we have agreed on usage notes and definitions)

  • update RDF
  • update change history

@riccardoAlbertoni riccardoAlbertoni added this to the DCAT3 2PWD milestone Feb 9, 2021
@riccardoAlbertoni riccardoAlbertoni added this to In progress in DCAT Sprint: Dataset Series via automation Feb 9, 2021
@agbeltran agbeltran self-requested a review February 9, 2021 19:43
dcat/index.html Outdated Show resolved Hide resolved
dcat/index.html Outdated Show resolved Hide resolved
DCAT Sprint: Dataset Series automation moved this from In progress to Review in progress Feb 9, 2021
dcat/index.html Outdated Show resolved Hide resolved
dcat/index.html Outdated Show resolved Hide resolved
dcat/index.html Outdated Show resolved Hide resolved
dcat/index.html Outdated Show resolved Hide resolved
@riccardoAlbertoni riccardoAlbertoni changed the title Dcat dataseries issue1272 Dataseries v2 (issue 1272) Feb 28, 2021
…hDiscussionOn1307

DatasetSeries: adding dcat:inSeries and its inverse, updating the  dataset examples.
@riccardoAlbertoni
Copy link
Contributor Author

dcat:hasSeriesMember and dcat:inSeries replace dcterm:hasPart and dcterms:isPartof as discussed in #1307.

Still, some discussion about these properties names, which I have reported in issues #1307 (comment)

@riccardoAlbertoni
Copy link
Contributor Author

The concerns from @agbeltran and @dr-shorthair have been addressed.

I would propose to merge this PR in the editorial draft as it includes many changes and it is useful to show these changes to commenters while we advance the discussion on the missing pieces (e.g., #1307 (comment))

@andrea-perego
Copy link
Contributor

@riccardoAlbertoni said:

The concerns from @agbeltran and @dr-shorthair have been addressed.

I would propose to merge this PR in the editorial draft as it includes many changes and it is useful to show these changes to commenters while we advance the discussion on the missing pieces (e.g., #1307 (comment))

I suggest we wait until tomorrow's DCAT call, to see if we reach an agreement.

@riccardoAlbertoni
Copy link
Contributor Author

@andrea-perego @agbeltran @dr-shorthair @pwin @davebrowning: could any of you check I haven't missed anything and accept the PR?
This PR should close issue #1307 and likely also #1272.

@andrea-perego
Copy link
Contributor

@andrea-perego @agbeltran @dr-shorthair @pwin @davebrowning: could any of you check I haven't missed anything and accept the PR?
This PR should close issue #1307 and likely also #1272.

+1 from me. Thanks, @riccardoAlbertoni .

Copy link
Contributor Author

@riccardoAlbertoni riccardoAlbertoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to making the references to issues consistent with those previously included in the document. Issue with a capital letter and # in front of numbers.

dcat/index.html Outdated Show resolved Hide resolved
dcat/index.html Outdated Show resolved Hide resolved
dcat/index.html Outdated Show resolved Hide resolved
@riccardoAlbertoni
Copy link
Contributor Author

@agbeltran: There is one old request for change from you blocking the merging. I think we have included your request. Could you unblock the merging accepting the PR? Thanks ;)

@riccardoAlbertoni riccardoAlbertoni dismissed agbeltran’s stale review March 23, 2021 16:19

The changes required by @Alejandra were included. This is a stale change request.

DCAT Sprint: Dataset Series automation moved this from Review in progress to Reviewer approved Mar 23, 2021
@riccardoAlbertoni riccardoAlbertoni merged commit be83b5c into gh-pages Mar 23, 2021
DCAT Sprint: Dataset Series automation moved this from Reviewer approved to Done Mar 23, 2021
@riccardoAlbertoni riccardoAlbertoni deleted the dcat-dataseries-issue1272 branch March 23, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Should we specialize dcterms:hasPart for dcat:DatasetSeries? A separate class for DatasetSeries (?)
4 participants