Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address 1536: extend the range of 'spatial resolution' #1543

Merged
merged 18 commits into from Jun 24, 2023

Conversation

the range now allows  in addition to .
I also added a note to explain the rationale of that change.

Should the note be copied in 6.8.13 as well?
Copy link
Contributor

@dr-shorthair dr-shorthair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will require a matching change to the TTL representation
https://github.com/w3c/dxwg/blob/gh-pages/dcat/rdf/dcat3.ttl#L1554

@andrea-perego andrea-perego added dcat spatial-resolution feedback Issues stemming from external feedback to the WG labels Nov 23, 2022
@andrea-perego andrea-perego added this to In progress in DCAT Sprint: Space and Time via automation Nov 23, 2022
@andrea-perego andrea-perego added this to the DCAT3 CR milestone Nov 23, 2022
@andrea-perego andrea-perego changed the title Address 1536: extend the range of 'sparial resolution' Address 1536: extend the range of 'spatial resolution' Nov 23, 2022
@jakubklimek
Copy link
Contributor

Do I understand it correctly, that the idea is that JSON-LD contexts of DCAT and DCAT profiles can choose one of:

  1. xsd:double datatype and JSON number representation
  2. xsd:decimal datatype and JSON string representation?

@pchampin
Copy link
Contributor Author

pchampin commented Dec 1, 2022

@dr-shorthair

I think this will require a matching change to the TTL representation

Right, but I'm not sure exactly what the process is for this (are some versions generated from others? difference between dcat3.* and dcat3-external.*...) so I would rather leave this to the editors.

@pchampin
Copy link
Contributor Author

pchampin commented Dec 1, 2022

Do I understand it correctly, that the idea is that JSON-LD contexts of DCAT and DCAT profiles can choose one of:

  1. xsd:double datatype and JSON number representation
  2. xsd:decimal datatype and JSON string representation?

or they can refrain to chose, and leave it to end users... Actually, both options are possible, as demonstrated in this example

@jakubklimek
Copy link
Contributor

@pchampin

or they can refrain to chose, and leave it to end users...

Well, technically, yes. But then the role of JSON-LD in "hiding RDF complexity for JSON users" is somehow diminished if we ask "JSON developers" to choose between

"spatialResolutionInMeters": {
   "@value": "3.14",
   "@type": "xsd:decimal"
}

and

"spatialResolutionInMeters": {
   "@value": 3.14,
   "@type": "xsd:double"
}

for, in JSON world, no apparent reason.

@pchampin
Copy link
Contributor Author

pchampin commented Dec 1, 2022

@jakubklimek
Developers that don't want to worry about the underlying RDF will simply use

  "spatialResolutionInMeters": 3.14

and that will be compliant with DCAT, thanks to the proposed change.

Developers who care about those details still have the opportunities to be more precise and use an xsd:decimal.

@jakubklimek
Copy link
Contributor

"spatialResolutionInMeters": 3.14

But this is not that simple. If they go this way, the will probably also use:

"spatialResolutionInMeters": 3

which produces a xsd:integer literal, which, yes, can be converted into xsd:decimal or xsd:double, but strictly speaking, is yet another datatype. That's why it is necessary to state whether the value is a xsd:decimal or xsd:double in the context (one or the other), or in the value.

@pchampin
Copy link
Contributor Author

@jakubklimek strictly speaking xsd:integer is derived from xsd:decimal (see spec), so having an xsd:integer where an xsd:decimal is perfectly legal semantically. OWL inference engines, for example, will not treat it as a contradiction.

Now, SHACL and ShEX are only concerned with syntax, and a shape requiring xsd:decimal will indeed choke on an xsd:integer value... A pragmatic approach would be for such shape to allow xsd:decimal OR xsd:integer whenever the domain is xsd:decimal. Note that this is an incomplete workaround, because xsd:decimal has many more derived datatype that could semantically be used, but xsd:integer is probably by far the most used.

I have added a comment (bcb5990) explaining this in the note below the definition of dcat:spatialResolutionInMeters.

NB: this issue with xsd:integer is not specific to JSON-LD. The same problem exists with Turtle...

@dr-shorthair
Copy link
Contributor

@andrea-perego can you clarify your position on this?

@dr-shorthair
Copy link
Contributor

It is arguably out of scope for DCAT to address issues in the JSON implementation of RDF.
It would be appropriate to add a warning that xsd:decimal is not supported in JSON, but I would be reluctant to add an alternative datatype, as too many choices compromises interoperability.

@dr-shorthair dr-shorthair self-assigned this Feb 8, 2023
riccardoAlbertoni and others added 3 commits June 21, 2023 12:40
Co-authored-by: Pierre-Antoine Champin <pierre-antoine@w3.org>
Rephasing  and removing the normative effect of proposal PR #1543
@riccardoAlbertoni
Copy link
Contributor

I have approved this PR as a consequence of the "rephasing and removing of normative effect" PR #1573 just merged here.

@dr-shorthair @andrea-perego @agbeltran @davebrowning @pwin : Can any of you approve and merge the resulting PR #1543 into the main branch.

DCAT Sprint: Space and Time automation moved this from In progress to Reviewer approved Jun 24, 2023
@dr-shorthair dr-shorthair merged commit e66153b into gh-pages Jun 24, 2023
1 check passed
DCAT Sprint: Space and Time automation moved this from Reviewer approved to Done Jun 24, 2023
@dr-shorthair dr-shorthair deleted the issue-1536 branch June 24, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dcat feedback Issues stemming from external feedback to the WG spatial-resolution
Development

Successfully merging this pull request may close these issues.

None yet

6 participants