Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing #1540 - schema.org aligment #1545

Merged
merged 6 commits into from Nov 25, 2022
Merged

Addressing #1540 - schema.org aligment #1545

merged 6 commits into from Nov 25, 2022

Conversation

dr-shorthair
Copy link
Contributor

Fix alignments - dcat:Catalog-sdo:DataCatalog dcat:Distribution-sdo:DataDownload

Fixes #1540

@riccardoAlbertoni
Copy link
Contributor

Thanks, Simon, for preparing this PR.
I understand we want to leave out the mapping with SOSA, but I have doubts about deleting the mapping with FOAF. FOAF, in my opinion, is comparable to DCT, for which we keep the mapping. DCAT directly uses only foaf:Agent, but mapping foaf:Agent's subclasses and properties might be relevant. Do you think it would do any harm to keep them?

@riccardoAlbertoni riccardoAlbertoni added this to In progress in DCAT Sprint: Feedback via automation Nov 22, 2022
@riccardoAlbertoni riccardoAlbertoni added this to the DCAT3 CR milestone Nov 22, 2022
@dr-shorthair
Copy link
Contributor Author

I've reinstated the FOAF mappings ... though it does seem a little cheeky given that @danbri is the boss of both.

@agbeltran
Copy link
Member

Should we update the turtle file in this same PR?

@dr-shorthair
Copy link
Contributor Author

This PR only touches the TTL file.

@agbeltran
Copy link
Member

agbeltran commented Nov 25, 2022 •
edited

sorry, yes! I was thinking about the spec but we don't add the relationship between entities in the table!

DCAT Sprint: Feedback automation moved this from In progress to Reviewer approved Nov 25, 2022
@agbeltran agbeltran merged commit f7ae7e6 into gh-pages Nov 25, 2022
DCAT Sprint: Feedback automation moved this from Reviewer approved to Done Nov 25, 2022
@agbeltran agbeltran deleted the dcat-issue-1540 branch November 25, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agbeltran agbeltran agbeltran approved these changes

@riccardoAlbertoni riccardoAlbertoni riccardoAlbertoni approved these changes

@andrea-perego andrea-perego Awaiting requested review from andrea-perego

@davebrowning davebrowning Awaiting requested review from davebrowning

@pwin pwin Awaiting requested review from pwin

Assignees
No one assigned
Labels
dcat
Projects
DCAT Sprint: Feedback
  
Done
Milestone
DCAT 3 CR
Development

Successfully merging this pull request may close these issues.

Alignment with schema.org
4 participants
@dr-shorthair @riccardoAlbertoni @agbeltran @andrea-perego