-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub-editing/Issue 301 #332
Conversation
Get up to date with master
Indentation had got out of control.
Minor nits and typos
@davebrowning I notice that many property descriptions in the rec include text in the 'Range:' section - e.g. https://w3c.github.io/dxwg/dcat/#Property:catalog_language - which has not made it into the RDF representation (i.e. the ttl file). This should probably be included as I have proposed something similar to add the scope notes for |
On this issue:
Since the association of many (most?) properties with classes is not axiomatized, but rather is just through normative text in the rec document, I wonder if we should copy down the list of inherited properties, instead of just saying 'In addition to the properties inherited from the super-class ...' - the links could still point back to the original documentation on the super-class, but it might be clearer to implementers what is expected. |
Good point on the range: sections on property descriptions - that's still outstanding (that is, I've fixed the English text in the rdf, but not addressed the ranges.) On repetition: yes, that might work. I'm against having inherited property definitions duplicated in their entirety, but listing them in the section as part of/immediately below the Class definition would be helpful. [Since I've been flipping between the 2014 spec and our work, the usefulness of having all the recommended properties for a class listed together stands out a bit....] |
This updated version of the UML shows the inherited properties more clearly: |
To be a bit more explicit - yes, that's a good step forward |
This set of changes aims to address the textual rules raised in issue #301. Along the way, there has been some clarifing textual changes ( in particular where the addition of services to catalogs hadn't been acknowledged) and a few broken internal links. There's a fair few small changes (There was also an indentation problem which has increased the line count....)
Some of these updates need to be reflected in the rdf (turtle) file but since some of the links to that don't work (see #320 ) yet and we need to address how that works for 2PWD, I'd like to ensure the changes are okay then I can cut and paste into the rdf and ensure the links work as needed
Questions/comments:
The document still repeats some properties in (e.g.
title
is indcat:Catalog
etc as well asdcat:Resource
. In general the definitions are now the same. Are we happy to define the properties once in the super class and make that change now?In general internal links to class definitions don't work in the editors draft - it looks to me that the respec process fixes that, but I'm following that up to make sure it's done correctly.