Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional text on scope of DCAT #650

Merged
merged 5 commits into from
Jan 12, 2019
Merged

Additional text on scope of DCAT #650

merged 5 commits into from
Jan 12, 2019

Conversation

dr-shorthair
Copy link
Contributor

Dealing with #649
Potentially also allowing #64, #530 to be resolved:

Simon Cox added 2 commits January 10, 2019 14:12
…rvices, and drawing attention to the role of dcat:Resource as an extension point for subclasses for other kinds of catalog.
Copy link
Contributor

@davebrowning davebrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good step forward - the substance seems fine to me.

Some small things - I could make these changes if you agree/like

  1. In DCAT scope this says "The resources described in a single catalog are published or curated by a single agent." I find the first single a bit strange/redundant - isn't the case that any resource has to be published/curated by a single agent, no matter which catalog it's been catalogued in?
  2. The phrase "DCAT profile or application" is used a few times - I'd have said "DCAT or application profile' since these are all cases of profiles. That would sit neater with the language in the profiles guidance, to my eye?
  3. There are a few references to dcat:Resource that aren't hyperlinked (And some old ones that are marked as <code> but not hyperlinked under the CatalogRecord paragraph)

@dr-shorthair
Copy link
Contributor Author

  1. This was copied over from the original. I tried to move it to a better place, but did not change the wording. But I am also not sure if it is right or useful. @makxdekkers might remember why it is there.

  2. Yeah - I was trying to capture the idea that there will be DCAT (application-)profiles (which describe a static vocabulary or schema) but also DCAT applications (which use DCAT to build a discipline- or community-specific application). Maybe a global search and replace "DCAT profile or application" with "DCAT application profile or other DCAT application" ?

  3. would be good to fix those ...

@davebrowning
Copy link
Contributor

I've addressed my observations (2) & (3) in this branch.

@makxdekkers
Copy link
Contributor

@davebrowning @dr-shorthair On point 1: no I don't remember why it was there, and I agree it's not a useful formulation.

@agbeltran
Copy link
Member

I removed the sentence 'The resources described in a single catalog are published or curated by a single agent.' and will merge now, as all the comments have been addressed.

@agbeltran agbeltran merged commit 0231a75 into gh-pages Jan 12, 2019
DCAT revision automation moved this from To do to Done Jan 12, 2019
@agbeltran agbeltran deleted the dcat-issue649-simon branch January 12, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
DCAT revision
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants