Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added definitions and scope-notes for dct: prov: foaf: and odrl: props #903

Merged
merged 5 commits into from
May 3, 2019

Conversation

dr-shorthair
Copy link
Contributor

@dr-shorthair dr-shorthair commented Apr 22, 2019

Content copied over from the rec document

As discussed in #725

@dr-shorthair dr-shorthair requested a review from pwin April 24, 2019 20:45
@dr-shorthair
Copy link
Contributor Author

  1. In cases where the DCAT CR has a 'definition' which is different to the external original, I have copied them into a skos:definition element ;

  2. In a few cases, the Usage Note is different in the context of different classes - typically replacing 'resource' with 'distribution' or similar. I have simply copied each usage note into a separate skos:scopeNote.

Copy link
Contributor

@davebrowning davebrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual change looks okay to me, but there is a conflict that needs addressing in the list of namespaces. (Would have just fixed that but realised I wasn't quite sure how it had come about - think the main branch has had some added (e.g. oa: earl:) but when I look in the conflict resolution screen it looks....strange....

@riccardoAlbertoni
Copy link
Contributor

@davebrowning :

Actual change looks okay to me, but there is a conflict that needs addressing in the list of namespaces. (Would have just fixed that but realised I wasn't quite sure how it had come about - think the main branch has had some added (e.g. oa: earl:) but when I look in the conflict resolution screen it looks....strange....

I have solved the conflict, my opinion is that we can drop the "<code></code>" tags and keep the namespace definitions we currently have in the gh-pages. I remember myself adding some of the additional namespaces as they were used in the document but not declared.

@davebrowning
Copy link
Contributor

Thanks @riccardoAlbertoni - that looks better now. [Not sure what github was showing me before but I'll put it down to my confusion...]

@davebrowning davebrowning merged commit 1118e2d into gh-pages May 3, 2019
DCAT revision automation moved this from To do to Done May 3, 2019
@davebrowning davebrowning deleted the dcat-issue725 branch May 3, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
DCAT revision
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants