Bump eslint from 8.26.0 to 9.0.0 (#1191)

* Bump eslint from 8.26.0 to 9.0.0

Bumps [eslint](https://github.com/eslint/eslint) from 8.26.0 to 9.0.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.26.0...v9.0.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* update with latest eslint version

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Denis Ah-Kang <denis@w3.org>

app.js

@@ -64,13 +64,13 @@ app.set('trust proxy', true);
 
 // Index Page
 app.get('/', (request, response) => {
-  // eslint-disable-next-line no-undef
+   
   response.sendFile(`${process.cwd()}/views/index.html`);
 });
 
 // New UI
 app.get('/ui', (request, response) => {
-  // eslint-disable-next-line no-undef
+   
   response.sendFile(`${process.cwd()}/views/web-interface.html`);
 });
 
@@ -99,7 +99,7 @@ app.get('/api/status', (req, res) => {
 
 function dumpJobResult(dest, result) {
   Fs.writeFile(dest, `${JSON.stringify(result, null, 2)}\n`, err => {
-    // eslint-disable-next-line no-console
+     
     if (err) console.error(err);
   });
 }
@@ -176,7 +176,7 @@ const processRequest = (req, res, isTar) => {
       '',
       new Map(
         jobList.reduce((object, value) => {
-          // eslint-disable-next-line no-param-reassign
+           
           object[value] = new Job();
           return object;
         }, {}),
@@ -205,13 +205,13 @@ const processRequest = (req, res, isTar) => {
       requests[id].results,
     )
       .then(async state => {
-        // eslint-disable-next-line no-console
+         
         console.log(`[${state.get('status').toUpperCase()}] ${url}`);
         dumpJobResult(
           `${argResultLocation + path.sep + id}.json`,
           requests[id],
         );
-        // eslint-disable-next-line no-console
+         
         if (dryRun) console.log('Dry-run: omitting e-mail notification');
         else {
           sendMessage(
@@ -247,7 +247,7 @@ passport.use(
 
     ldap.authenticate(username, password, (err, user) => {
       if (err) {
-        // eslint-disable-next-line no-console
+         
         console.log('LDAP auth error: %s', err);
       }
       done(null, user);
@@ -286,12 +286,12 @@ app.post(
 
 app.listen(process.env.PORT || port).on('error', err => {
   if (err) {
-    // eslint-disable-next-line no-console
+     
     console.error(`Error while trying to launch the server: “${err}”.`);
   }
 });
 
-// eslint-disable-next-line no-console
+ 
 console.log(
   `${meta.name} version ${meta.version} running on ${
     process.platform

assets/js/behaviour.js

@@ -1,4 +1,4 @@
-/* eslint-disable no-alert */
+ 
 /**
  * Behaviour of the Echidna UI.
  *

eslint.config.cjs

@@ -0,0 +1,47 @@
+[
+  {
+    "extends": ["airbnb-base", "prettier", "plugin:node/recommended"],
+    "plugins": ["prettier", "node"],
+    "env": {
+      "node": true,
+      "es2022": true
+    },
+    "parserOptions": {
+      "ecmaVersion": 2022,
+      "allowImportExportEverywhere": true
+    },
+    "rules": {
+      "prettier/prettier": "error",
+      "strict": "off",
+      "consistent-return": "off",
+      "import/extensions": "off",
+      "global-require": "off",
+      "no-restricted-syntax": "warn",
+      "guard-for-in": "warn",
+      "prefer-destructuring": "warn",
+      "import/prefer-default-export": "off",
+      "no-unpublished-import": "off",
+      "node/no-unsupported-features/es-syntax": [
+        "warn",
+        {
+          "version": ">=18.0.0",
+          "ignores": ["modules"]
+        }
+      ]
+    },
+    "overrides": [
+      {
+        "files": ["test/**/*.js"],
+        "env": {
+          "mocha": true
+        }
+      },
+      {
+        "files": ["assets/**/*.js"],
+        "env": {
+          "browser": true
+        }
+      }
+    ]
+  }
+];

lib/ip-checker.js

@@ -13,9 +13,9 @@ import path from 'path';
 import { fileURLToPath } from 'url';
 
 const { List } = pkg;
-// eslint-disable-next-line no-underscore-dangle
+ 
 const __filenameNew = fileURLToPath(import.meta.url);
-// eslint-disable-next-line no-underscore-dangle
+ 
 const __dirname = path.dirname(__filenameNew);
 
 /**
@@ -35,7 +35,7 @@ IPChecker.check = ip =>
     const ghIp = octokit.request('GET /meta');
     // downloaded from https://www.microsoft.com/en-us/download/details.aspx?id=56519
     const azureIp = fs.promises
-      // eslint-disable-next-line no-undef
+       
       .readFile(`${__dirname}/../ServiceTags_Public.json`)
       .then(JSON.parse);
     Promise.all([ghIp, azureIp])
@@ -62,7 +62,7 @@ IPChecker.check = ip =>
         }
         resolve(errors);
       })
-      // eslint-disable-next-line no-console
+       
       .catch(e => console.error(e));
   });
 

lib/job.js

@@ -33,7 +33,7 @@ function Job(status, errors) {
    * @param {*} v - The value to set
    * @returns {Job} The resulting job
    */
-  // eslint-disable-next-line consistent-return
+   
   this.set = (k, v) => {
     switch (k) {
       case 'status':

lib/mailer.js

@@ -1,7 +1,7 @@
 /**
  * @file Send e-mail notification about a publication job. Called by app.js after Orchestrator has initiated the jobs.
  */
-/* eslint-disable no-console */
+ 
 
 'use strict';
 
@@ -14,9 +14,9 @@ import SpecberusWrapper from './specberus-wrapper.js';
 import { importJSON } from './util.js';
 
 const meta = importJSON('../package.json', import.meta.url);
-// eslint-disable-next-line no-underscore-dangle
+ 
 const __filenameNew = fileURLToPath(import.meta.url);
-// eslint-disable-next-line no-underscore-dangle
+ 
 const __dirname = path.dirname(__filenameNew);
 
 const mailTemplatesDir = `${__dirname}/../assets/mail-templates/`;
@@ -230,7 +230,7 @@ const sendMessage = async (id, state, json, url, ccEmail, decision) => {
     ];
   } else message.text = message.text.replace('@ATTACHMENT', '');
 
-  // eslint-disable-next-line consistent-return
+   
   transporter.sendMail(message, (error, info) => {
     if (error) return console.log(error);
     console.log(`Message ${info.messageId} sent: ${info.response}`);

lib/specberus-wrapper.js

@@ -1,5 +1,4 @@
-/* eslint-disable node/no-unsupported-features/es-syntax */
-/* eslint-disable global-require */
+
 /**
  * @file A [Specberus](https://github.com/w3c/specberus) wrapper. Validate the compliance of Technical Reports with [publication rules](https://www.w3.org/pubrules/doc).
  */
@@ -58,7 +57,7 @@ SpecberusWrapper.validate = (url, stateMetadata) =>
       reject(new Error(exception.message));
     });
 
-    // eslint-disable-next-line consistent-return
+     
     (async () => {
       const profile = stateMetadata.get('profile');
       const patentPolicy = stateMetadata.get('patentPolicy');

lib/transition-checker.js

@@ -70,7 +70,7 @@ TransitionChecker.check = (
             sort: 'updated',
             per_page: 100, // TODO: get all the issues, not just the first 100
           })
-          // eslint-disable-next-line consistent-return
+           
           .then(content => {
             const issueFound = content.items.some(issue => {
               if (issue.title.endsWith(` ${shortname}`)) {

package.json

@@ -43,7 +43,7 @@
     "@rvagg/chai-as-promised": "8.0.1",
     "coveralls": "3.1.1",
     "cspell": "8.0.0",
-    "eslint": "8.26.0",
+    "eslint": "9.0.0",
     "eslint-config-airbnb-base": "15.0.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-import": "2.26.0",