-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requestMediaKeySystemAccess()'s supportedConfigurations parameter should not be optional #1
Comments
+1 |
The next questions are:
I think #1 should be "No." We don't allow empty sequences, arrays, or strings elsewhere in the spec. For #2, I don't think the dictionaries can technically be empty because a few of the members have default values. We could consider requiring values for other members, though there are legitimate reasons for them to be empty. For example, no audio or video track. Even Should we just require a sequence with >= 1 elements, regardless of what they contain? I think this still achieves the simplification we're looking for, but it is a bit weird that the following is valid (and the workaround to removing
|
The complexity of the single-parameter version also trickles down to MediaKeySystemAccess, which may return null from getConfiguration() because of this case. |
As discussed in the telecon this morning, I will implement this. For now, we will allow empty dictionary(ies) (e.g. |
The |supportedConfigurations| parameter is required by the fix for issue #1.
Currently, requestMediaKeySystemAccess() can be called with just a Key System name. However, I cannot think of a valid use case where an application should not also be providing at least a content type. There is no point in getting a MediaKeySystemAccess or MediaKeys object that cannot be used with the content. Supporting the single parameter version just adds complexity to the specification (a branch and extra algorithm) and implementations. We should make supportedConfigurations required.
The text was updated successfully, but these errors were encountered: