Issue #80: Times in the record of key usage should be at session level #87
Conversation
|
I agree with all @ddorwin 's suggestions. For the questions: (1) Do you need to add the key IDs here or is that already handled by update()? They need to be added somewhere. I'll check and address. (2) Is "tfirst" consistent with good JSON naming practices? I don't know. Happy to take suggestions. |
|
The needs implementation label was making searches confusing, so I removed it. |
| </li> | ||
| </ul> | ||
| <p> | ||
| A <a def-id="message"></a> of type <a def-id="message-type-license-release"></a> containing the <a def-id="record-of-key-usage"></a> will be generated when <a def-id="remove"></a> is called until the record is acknowledged by a response passed to <a def-id="update"></a>. |
There was a problem hiding this comment.
We should probably look at the behavior of sessions and calling remove() after the record is acknowledged in an update() call. Nothing specific to change in this PR, but this text makes me wonder.
|
Are we ready to merge this now ? (No green button will be pressed ...) |
|
Oh, I missed that there were new commits as I only saw the comments in email. I will try to take a look tomorrow. |
|
The last two (non-merge) commits LGTM. Thanks. |
|
Merged as 7a55532 |
No description provided.