-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename tests to match w3c/epub-specs#1685 #20
Conversation
Discussed in face-to-face, and everyone is fine with this. I will merge this PR and rename others in a followup, and will wait for approval on w3c/epub-specs#1685. |
The issue was discussed in a meeting on 2021-05-28
View the transcript4. testingSee github pull request epub-tests#20, #1685.
Dan Lazin: state of testing: some are easy, many are tricky. I put together a spreadsheet that breaks down the rs spec at the time into testable normative statement. Ivan Herman: need to think about how to report results in a consistent format - some sort of data file that includes metadata about the tests
Dan Lazin: we are going to have a lot more failures than audiobooks testing Ivan Herman: CR has to prove that spec is implementable through >2 cited implementations dawhe: one example is manifest fallbacks, which is not widely supported across reading systems Dan Lazin: maybe we need a regular testing meeting to help answer questions as they come up dawhe: I would attend such a meeting Tzviya Siegman: we need help putting EPUB 3.3 into epubcheck Matt Garrish: I've been doing this as we go along Ivan Herman: what is the role of EPUBcheck in our testing strategy? In some sense it's an implementation Matt Garrish: we have a lot of features that are rarely used, or only used by a single feature. Does that mean we should deprecade stuff that isn't in wide use? Ivan Herman: maybe we have to have a list of those features where we have doubts that they are widely used Matt Garrish: we did a survey of publishers for 3.1 Ivan Herman: we are obliged to honor backwards compatibility, but don't have to keep features that nobody uses George Kerscher: pronunciation task force is putting forth a new proposal; we should harmonize our requirements with theirs Wendy Reid: we don't know if manifest fallbacks are used by anyone - should we do a survey across publishers and reading systems for this type of questionable feature? Charles LaPierre: if we can't find implementations, we could deprecate those because we can't find 2 implementations Tzviya Siegman: we did an investigation for epub cfi to see if they were in use in Google books Matt Garrish: it gets complicated when we drop specs from authoring but not reading systems or vice-versa so it would have to have zero support anywhere to have no impact
dawhe: it's a disservice to authors if they have stuff in their content that we know doesn't work Charles LaPierre: new developers have to support legacy code; we shouldn't keep supporting if not necessary Matt Garrish: if we drop fallbacks, are images in the spine valid? there is a ripple effect to getting rid of stuff George Kerscher: mathml continues to be poorly implemented, but that's a core component of something we really need and support will slowly improve over time Ivan Herman: there is no risk for mathml even though implementation needs to be improved Dan Lazin: if we have a weekly meeting we can go through these topics. epubtest repo had a nested hierarchy - does this organization make sense or should it just be flat? Dave Cramer: fine with me Wendy Reid: sounds like we have agreed to a regular testing call. We can discuss organization of tests and how to formulate results. Ivan Herman: Dan, you own the repository and can organize it the way you want. Brady Duga: there is a large provider that uses a bunch of different ways to render Matt Garrish: do you want us to review the PR? Dan Lazin: I would like people to review the individual tests to validate my interpretation of the spec Matt Garrish: so the specs will be coupled with the tests Dan Lazin: yes |
As explained in w3c/epub-specs#1685, if this is acceptable, in a subsequent PR I will rename other existing tests (not written by me) to match, and add data-test attributes for them too.