-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional FXL Layout tests #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - able to open all tests.
These tests may have to be changed/adapted to the outcome of w3c/epub-specs#2453. Should be considered as a draft for the time being. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested in a comment inline: the test case for invalid viewport meta only tests one possible (invalid) pattern. More cases can be conceived, but I don't know if the intent is to be thorough or to have only one key test.
Three new tests:
Edited on 2022-10-15: as a result of #235 (comment) the content of the PR has changed:
Also, an older test has been updated to use patterns instead of colors only, to make it usable for b/w/ displays.