Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional FXL Layout tests #235

Merged
merged 4 commits into from
Oct 16, 2022
Merged

Additional FXL Layout tests #235

merged 4 commits into from
Oct 16, 2022

Conversation

iherman
Copy link
Member

@iherman iherman commented Oct 4, 2022

Three new tests:

  • Viewport w/h are set to device-width and device-height, respectively
  • No viewport is set (should use device-width and device-height)
  • Erronuous viewport is set (should use device-width and device-height)

Edited on 2022-10-15: as a result of #235 (comment) the content of the PR has changed:

  • Viewport w/h are set to device-width and device-height, respectively
  • Reading systems SHOULD attempt to extract 'width' and 'height' values even if the tag's syntax is invalid.
  • Reading system should use the first declaration of a 'width' or 'height' (i.e., ignore repeated declarations).

Also, an older test has been updated to use patterns instead of colors only, to make it usable for b/w/ displays.

Copy link
Contributor

@davemanhall davemanhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - able to open all tests.

@iherman
Copy link
Member Author

iherman commented Oct 11, 2022

These tests may have to be changed/adapted to the outcome of w3c/epub-specs#2453. Should be considered as a draft for the time being.

@iherman iherman marked this pull request as draft October 11, 2022 10:08
Copy link
Member

@rdeltour rdeltour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested in a comment inline: the test case for invalid viewport meta only tests one possible (invalid) pattern. More cases can be conceived, but I don't know if the intent is to be thorough or to have only one key test.

@iherman iherman marked this pull request as ready for review October 15, 2022 04:18
@iherman iherman merged commit efcb198 into main Oct 16, 2022
@iherman iherman deleted the extra_icb_tests branch October 16, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants