-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test for fixed layout properties #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the same as #33, just from today's demo? If so, which would you like me to review? If not the same, can you explain what's different here?
(Resolved now.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the two .DS_Store files.
<dc:creator>Wendy Reid</dc:creator> | ||
<dc:date>2021-09-24</dc:date> | ||
<dc:description>When rendition:layout is pre-paginated, reading systems must display one page per spine item.</dc:description> | ||
<dc:identifier id="pub-id">fxl-properties-002</dc:identifier> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should either be def-layout-pre-paginated (https://www.w3.org/TR/epub-rs-33/#def-layout-pre-paginated) or a new ID created on the <dd> or <p> below it, please.
Then rename this test directory to match the ID, please.
If you create a new ID, please also update line 11.
…nto fxl-properties2
…nto fxl-properties2
Adding test for fxl-properties-002. Please review.