Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for fixed layout properties #37

Merged
merged 16 commits into from
Nov 4, 2021
Merged

Adding test for fixed layout properties #37

merged 16 commits into from
Nov 4, 2021

Conversation

wareid
Copy link
Contributor

@wareid wareid commented Sep 24, 2021

Adding test for fxl-properties-002. Please review.

Copy link
Collaborator

@dlazin dlazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same as #33, just from today's demo? If so, which would you like me to review? If not the same, can you explain what's different here?

@dlazin
Copy link
Collaborator

dlazin commented Oct 28, 2021

Is this the same as #33, just from today's demo? If so, which would you like me to review? If not the same, can you explain what's different here?

(Resolved now.)

Copy link
Collaborator

@dlazin dlazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the two .DS_Store files.

<dc:creator>Wendy Reid</dc:creator>
<dc:date>2021-09-24</dc:date>
<dc:description>When rendition:layout is pre-paginated, reading systems must display one page per spine item.</dc:description>
<dc:identifier id="pub-id">fxl-properties-002</dc:identifier>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should either be def-layout-pre-paginated (https://www.w3.org/TR/epub-rs-33/#def-layout-pre-paginated) or a new ID created on the <dd> or <p> below it, please.

Then rename this test directory to match the ID, please.

If you create a new ID, please also update line 11.

@wareid wareid merged commit 93d5960 into main Nov 4, 2021
@iherman iherman deleted the fxl-properties2 branch July 30, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants