FXL Properties - Orientation Tests #91
Conversation
| <metadata xmlns:dc="http://purl.org/dc/elements/1.1/"> | ||
| <dc:coverage>Fixed Layout</dc:coverage> | ||
| <dc:creator>Wendy Reid</dc:creator> | ||
| <dc:date>2021-09-28</dc:date> |
There was a problem hiding this comment.
Consider updating this date to match the _default test.
| <link rel="dcterms:rights" href="https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document"/> | ||
| <link rel="dcterms:rightsHolder" href="https://www.w3.org"/> | ||
| <meta property="dcterms:isReferencedBy">https://www.w3.org/TR/epub-33/#orientation</meta> | ||
| <meta property="dcterms:modified">2021-01-01T00:00:00Z</meta> |
There was a problem hiding this comment.
Update this to match the above, please.
| <dc:coverage>Fixed Layout</dc:coverage> | ||
| <dc:creator>Wendy Reid</dc:creator> | ||
| <dc:date>2021-09-28</dc:date> | ||
| <dc:description>EPUB creators must not declare the orienation property more than once.</dc:description> |
There was a problem hiding this comment.
I guess this is our first intentional core-spec test. Should this say something like "EPUBCheck should produce an error."?
There was a problem hiding this comment.
Also I think the description should be in this format: "rendition:orientation is specified twice. EPUBCheck should produce an error."
There was a problem hiding this comment.
Also, note typo: "orienation"
| <dc:description>EPUB creators must not declare the orienation property more than once.</dc:description> | ||
| <dc:identifier id="pub-id">fxl-orientation_duplicate</dc:identifier> | ||
| <dc:language>en</dc:language> | ||
| <dc:title>rendition:orientation duplicate</dc:title> |
There was a problem hiding this comment.
Nit: "duplication", to match your other <title> elements. Noun is better in a title anyway.
| <dc:coverage>Fixed Layout</dc:coverage> | ||
| <dc:creator>Wendy Reid</dc:creator> | ||
| <dc:date>2021-09-28</dc:date> | ||
| <dc:description>Reading systems should display or inform the user of the intended orientation of the EPUB.</dc:description> |
There was a problem hiding this comment.
Please rewrite to be in the same format as other descriptions: "rendition:orientation is X, so Y".
| <dc:description>Reading systems should display or inform the user of the intended orientation of the EPUB.</dc:description> | ||
| <dc:identifier id="pub-id">fxl-orientation_landscape</dc:identifier> | ||
| <dc:language>en</dc:language> | ||
| <dc:title>rendition:orientation portrait</dc:title> |
There was a problem hiding this comment.
This says portrait, but it's landscape on line 16.
I did consider this, but I think what I want to focus on is the RS behaviour as described in the spec, and portrait or landscape, the SHOULD focuses on the RS either displaying in that orientation or informing the user that the content author would like that orientation shown. I actually am really curious about this because it might actually be under-supported. It's easy enough to add a portrait one if you feel I should go that route though. |
OK, up to you! |
| <dc:coverage>Fixed Layout</dc:coverage> | ||
| <dc:creator>Wendy Reid</dc:creator> | ||
| <dc:date>2021-11-18</dc:date> | ||
| <dc:description>rendition:orientation is landscape, Reading Systems should either display the content in landscape or inform the user it should be.</dc:description> |
There was a problem hiding this comment.
Nit: comma splice! Either use a period, colon, or semi-colon instead of the comma, or add a word like "so".
There was a problem hiding this comment.
And while we're at it, I prefer your wording on the pages themselves: "inform the user it should be viewed in landscape."
Testing the Orientation properties. These tests cover the default statement, the SHOULD in RS, and the MUST NOT in the core spec (will add appropriate test hooks).