Adding tests for spread and page-spread properties #94
Conversation
|
@wareid can you explain the "accidental"? Put it another way, what parts are to be safely ignored in a review? Otherwise it is difficult to review the PR... |
I got a bit carried away and did more tests in one branch than I meant to :). |
Only page one should display in the centre, and the remainder should be in spreads/alone. |
Fixing the label, but yes a PR is incoming for the specs. |
Right. And none of the RS-s that I tested with do that :-( But if we are confident the test is correct, then we are fine at this point! I just wanted to be sure... |
| <dc:creator>Wendy Reid</dc:creator> | ||
| <dc:date>2021-11-24</dc:date> | ||
| <dc:description>When rendition:page-spread-right and -left are applied to adjacent spine items, they should be displayed in a synthetic spread.</dc:description> | ||
| <dc:identifier id="pub-id">fxl-page-spread_combined</dc:identifier> |
There was a problem hiding this comment.
As mentioned in the spec PR, the test ID should ideally match the anchor ID. Since the anchor doesn't have "combined," can you make them match?
|
Think I've addressed everything, let me know if it's ok and I'll make the EPUBs and test them and merge. |
| <dc:creator>Wendy Reid</dc:creator> | ||
| <dc:date>2021-11-24</dc:date> | ||
| <dc:description>When rendition:page-spread-right and -left are applied to adjacent spine items, they should be displayed in a synthetic spread.</dc:description> | ||
| <dc:identifier id="pub-id">fxl-page-spread_combined</dc:identifier> |
| <meta property="dcterms:modified">2021-11-24T00:00:00Z</meta> | ||
| <meta property="rendition:layout">pre-paginated</meta> | ||
| <meta property="rendition:spread">landscape</meta> | ||
| <meta property="belongs-to-collection">should</meta> |
There was a problem hiding this comment.
Alphabetize above dc section, please.
| <meta property="dcterms:isReferencedBy">https://www.w3.org/TR/epub-rs-33/#page-layout-both</meta> | ||
| <meta property="dcterms:modified">2021-11-24T00:00:00Z</meta> | ||
| <meta property="rendition:layout">pre-paginated</meta> | ||
| <meta property="belongs-to-collection">should</meta> |
There was a problem hiding this comment.
Alphabetize above dc section, please.
Co-authored-by: Dan Lazin <dlazin@users.noreply.github.com>
Co-authored-by: Dan Lazin <dlazin@users.noreply.github.com>
Co-authored-by: Dan Lazin <dlazin@users.noreply.github.com>
Co-authored-by: Dan Lazin <dlazin@users.noreply.github.com>
Co-authored-by: Dan Lazin <dlazin@users.noreply.github.com>
Co-authored-by: Dan Lazin <dlazin@users.noreply.github.com>
Co-authored-by: Dan Lazin <dlazin@users.noreply.github.com>
Accidental mega-test thread, this tests the properties of both rendition:spread and rendition:page-spread-*.
As a special bonus, there are also 2 tests for content where rendition:layout is applied in the spine.
EPUBs will be added to this PR after all changes have been addressed to save myself some pain :).