Skip to content

Commit

Permalink
feat: revert the spine/toc nav order check to a WARNING
Browse files Browse the repository at this point in the history
As agreed on the 2019-07-11 EPUB CG call:
https://www.w3.org/2019/07/11-epub3cg-minutes.html

Changes the behavior introduced in #999

Fixes #1036
  • Loading branch information
rdeltour committed Jul 11, 2019
1 parent ead7480 commit 348d1bb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ private void initialize()
severities.put(MessageId.NAV_008, Severity.USAGE);
severities.put(MessageId.NAV_009, Severity.ERROR);
severities.put(MessageId.NAV_010, Severity.ERROR);
severities.put(MessageId.NAV_011, Severity.ERROR);
severities.put(MessageId.NAV_011, Severity.WARNING);

// NCX
severities.put(MessageId.NCX_001, Severity.ERROR);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,15 +213,15 @@ public void testValidateNav_TocInReadingOrder()
public void testValidateNav_TocWrongOrderInSpine()
{
// test that toc nav links MUST be in spine order
expectedErrors.add(MessageId.NAV_011);
expectedWarnings.add(MessageId.NAV_011);
testValidateDocument("invalid/nav-toc-unordered-spine");
}

@Test
public void testValidateNav_TocWrongOrderOfFragments()
{
// test that toc nav links MUST be in document order
expectedErrors.addAll(Collections.nCopies(2, MessageId.NAV_011));
expectedWarnings.addAll(Collections.nCopies(2, MessageId.NAV_011));
testValidateDocument("invalid/nav-toc-unordered-fragments");
}

Expand All @@ -236,15 +236,15 @@ public void testValidateNav_PageListInReadingOrder()
public void testValidateNav_PageListWrongOrderInSpine()
{
// test that page-list nav links MUST be in spine order
expectedErrors.add(MessageId.NAV_011);
expectedWarnings.add(MessageId.NAV_011);
testValidateDocument("invalid/nav-page-list-unordered-spine");
}

@Test
public void testValidateNav_PageListWrongOrderOfFragments()
{
// test that page-list nav links MUST be in document order
expectedErrors.add(MessageId.NAV_011);
expectedWarnings.add(MessageId.NAV_011);
testValidateDocument("invalid/nav-page-list-unordered-fragments");
}

Expand Down

0 comments on commit 348d1bb

Please sign in to comment.