Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch NuValidator's StackOverflowError #1096

Closed
tofi86 opened this issue Jan 14, 2020 · 1 comment
Closed

Catch NuValidator's StackOverflowError #1096

tofi86 opened this issue Jan 14, 2020 · 1 comment
Assignees
Labels
status: wontfix The issue is rejected due to limitations (of scope or dev resources)
Milestone

Comments

@tofi86
Copy link
Collaborator

tofi86 commented Jan 14, 2020

For pagina EPUB-Checker I updated the Windows wrapper to add the JVM argument -Xss1024k as suggested in https://github.com/w3c/epubcheck/wiki/Running#javalangstackoverflowerror but it seems that on certain systems this does not help and the SOE is still thrown. This leads to an unwanted situation: EPUBCheck is finished "successfully without errors or warnings" – but only because no checks were performed at all because of the SOE.

grafik

This can be reproduced on Mac and Windows by setting -Xss144k for example and checking a medium or large sized book.

Is there any chance to throw a FATAL exception if the NuValidator crashes?

And as a workaround I'm looking for a way to catch the previously uncaught SO-Errors when running EpubCheck.doValidate()? Does anyone know of a solution for that? Hint: Wrapping EpubCheck.doValidate() in a try/catch does not work ;-)

Thanks, Tobias

@rdeltour rdeltour self-assigned this Dec 8, 2022
@rdeltour rdeltour added this to the v5.0.0-rc milestone Dec 8, 2022
@rdeltour rdeltour added type: improvement The issue suggests an improvement of an existing feature status: accepted Ready to be further processed labels Dec 8, 2022
@rdeltour
Copy link
Member

By essence a StackOverflowError indicates a serious issue that is likely unrecoverable, and I don't think it would make much sense (nor would be much helpful) to catch that.

I'm closing the issue as wontfix, but feel free to keep commenting here if anyone can suggest a better handling!

@rdeltour rdeltour added status: wontfix The issue is rejected due to limitations (of scope or dev resources) and removed type: improvement The issue suggests an improvement of an existing feature status: accepted Ready to be further processed labels Dec 30, 2022
@rdeltour rdeltour closed this as not planned Won't fix, can't repro, duplicate, stale Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wontfix The issue is rejected due to limitations (of scope or dev resources)
Projects
None yet
Development

No branches or pull requests

2 participants