Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that media overlays total duration matches individual durations #1217

Closed
mattgarrish opened this issue Mar 14, 2021 · 0 comments
Closed

Check that media overlays total duration matches individual durations #1217

mattgarrish opened this issue Mar 14, 2021 · 0 comments
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Milestone
v5.0.0-beta

Comments

@mattgarrish
Copy link
Member

A mismatch should be reported as a warning.

w3c/epub-specs#1322
@mattgarrish mattgarrish added the spec: EPUB 3.3 Impacting the support of EPUB 3.3 label Mar 14, 2021
@rdeltour rdeltour added the status: accepted Ready to be further processed label Nov 13, 2021
@rdeltour rdeltour added this to the v5.0.0-beta-1 milestone Nov 13, 2021
@rdeltour rdeltour added status: ready for implem The issue is ready to be implemented status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed status: ready for implem The issue is ready to be implemented labels Jan 23, 2022
rdeltour added a commit that referenced this issue Jul 8, 2022
@rdeltour
feat: check Media Overlays total duration consistency
ee9c720 
EPUB 3.3 now recommends that the total MO duration equals the sum of
individual MO durations.

This commit:
- implements this check by inspecting metadata in the OPF
checker, using the `SmilClock` class to sum the durations.
- tweak existing tests to make their declared total duration matching
the individual durations

Fix #1217
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team labels Sep 22, 2022
@rdeltour rdeltour mentioned this issue Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Projects
None yet
Milestone
v5.0.0-beta
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish