Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that refines attribute references publication resources by manifest item id #1226

Closed
mattgarrish opened this issue Mar 14, 2021 · 0 comments
Closed

Check that refines attribute references publication resources by manifest item id #1226

mattgarrish opened this issue Mar 14, 2021 · 0 comments
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Milestone
v5.0.0-beta

Comments

@mattgarrish
Copy link
Member

It is now formally recommended that the refines attribute use fragment identifiers to reference resources listed in the manifest.

w3c/epub-specs#1361
@mattgarrish mattgarrish added the spec: EPUB 3.3 Impacting the support of EPUB 3.3 label Mar 14, 2021
@rdeltour rdeltour added this to the v5.0.0-beta-1 milestone Nov 12, 2021
@rdeltour rdeltour added the status: in progress The issue is being implemented by the development team label Nov 13, 2021
rdeltour added a commit that referenced this issue Jul 8, 2022
@rdeltour
feat: update checking of the Package Document 'refines' attribute
72366b4 
- `refines` MUST be a relative URL
- `refines` SHOULD refer to a Publication Resource by ID
- `refines` MUST point to an existing ID when it is a fragment-only URL

Fix #1226
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team labels Sep 22, 2022
@rdeltour rdeltour mentioned this issue Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Projects
None yet
Milestone
v5.0.0-beta
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish