Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landmarks nav should not include nested lists #1279

Closed
mattgarrish opened this issue Sep 9, 2021 · 0 comments
Closed

Landmarks nav should not include nested lists #1279

mattgarrish opened this issue Sep 9, 2021 · 0 comments
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Milestone
v5.0.0-beta

Comments

@mattgarrish
Copy link
Member

Part of clarifying the use of the landmarks nav in w3c/epub-specs#1761 was to match its content model to the page list, which recommends against nested lists.

There should also be a warning for the landmarks nav now if nested lists are used.
@mattgarrish mattgarrish added the spec: EPUB 3.3 Impacting the support of EPUB 3.3 label Sep 9, 2021
@mattgarrish mattgarrish changed the title Landmarks nav should include nested lists Landmarks nav should not include nested lists Sep 9, 2021
@rdeltour rdeltour added the status: accepted Ready to be further processed label Nov 13, 2021
@rdeltour rdeltour added this to the v5.0.0-beta-1 milestone Nov 13, 2021
@rdeltour rdeltour added status: ready for implem The issue is ready to be implemented status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed status: ready for implem The issue is ready to be implemented labels Jan 23, 2022
rdeltour added a commit that referenced this issue Jul 8, 2022
@rdeltour
feat: check that 'page-list' and 'landmarks' nav are flat lists
15825a5 
EPUB 3.3 clarifies that authors should not use nested lists for
'page-list' and 'landmarks' nav.

This commit:
- reports a schema warning for nested 'page-list' or 'landmarks' nav
  (implemented in schematron)
- add tests

Fix #1279
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team labels Sep 22, 2022
@rdeltour rdeltour mentioned this issue Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Projects
None yet
Milestone
v5.0.0-beta
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish