Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to work with Saxon 11.3 #1341

Closed
raducoravu opened this issue Jul 11, 2022 · 1 comment · Fixed by #1448
Closed

Update code to work with Saxon 11.3 #1341

raducoravu opened this issue Jul 11, 2022 · 1 comment · Fixed by #1448
Assignees
@rdeltour
Labels
status: has PR The issue is being processed in a pull request type: maintenance The issue is related to a meta task (build system, dependency update, etc)
Milestone
v5.0.0-rc

Comments

@raducoravu
Copy link

Right now EpubCheck depends on 9.8.0-8, maybe you could consider upgrading it to support Saxon 11.3.
rdeltour added a commit that referenced this issue Dec 7, 2022
@rdeltour
feat: update Saxon library to v11.4
44cbc47 
This commit updates the Saxon-HE dependency to version 11.4.

It refactors the Saxon-related code as follows:
- update the function+registration code to the latest API changes
- extract the Saxon schema reader factory (used by Jing) in its own class
- the Saxon schema reader factory is made available to Jing via the SPI
  mechanism (declared in
  `META-INF/services/com.thaiopensource.validate.SchemaReaderFactory`).
  This notably allows Jing to find and use our factory for both Schematron
  and NVDL.
- the Saxon schema reader factory no longer extends Jing's
  `NewSaxonSchemaReaderFactory`, which set the feature "XSLT_VERSION"
  to "2.0" and caused a Warning to be issued by Saxon 11.

Fix #1341
rdeltour added a commit that referenced this issue Dec 7, 2022
@rdeltour
feat: update Saxon library to v11.4
e93b5ba 
This commit updates the Saxon-HE dependency to version 11.4.

It refactors the Saxon-related code as follows:
- update the function+registration code to the latest API changes
- extract the Saxon schema reader factory (used by Jing) in its own class
- the Saxon schema reader factory is made available to Jing via the SPI
  mechanism (declared in
  `META-INF/services/com.thaiopensource.validate.SchemaReaderFactory`).
  This notably allows Jing to find and use our factory for both Schematron
  and NVDL.
- the Saxon schema reader factory no longer extends Jing's
  `NewSaxonSchemaReaderFactory`, which set the feature "XSLT_VERSION"
  to "2.0" and caused a Warning to be issued by Saxon 11.

Fix #1341
@rdeltour rdeltour mentioned this issue Dec 7, 2022
Merged
@rdeltour rdeltour added this to the v5.0.0-rc milestone Dec 8, 2022
@rdeltour rdeltour self-assigned this Dec 8, 2022
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request type: maintenance The issue is related to a meta task (build system, dependency update, etc) labels Dec 8, 2022
@rdeltour rdeltour linked a pull request Dec 8, 2022 that will close this issue
feat: update Saxon library to v11.4 #1448
Merged
rdeltour added a commit that referenced this issue Dec 9, 2022
@rdeltour
feat: update Saxon library to v11.4
ef2697e 
This commit updates the Saxon-HE dependency to version 11.4.

It refactors the Saxon-related code as follows:
- update the function+registration code to the latest API changes
- extract the Saxon schema reader factory (used by Jing) in its own class
- the Saxon schema reader factory is made available to Jing via the SPI
  mechanism (declared in
  `META-INF/services/com.thaiopensource.validate.SchemaReaderFactory`).
  This notably allows Jing to find and use our factory for both Schematron
  and NVDL.
- the Saxon schema reader factory no longer extends Jing's
  `NewSaxonSchemaReaderFactory`, which set the feature "XSLT_VERSION"
  to "2.0" and caused a Warning to be issued by Saxon 11.

Fix #1341
@raducoravu
Copy link
Author

Great thanks @rdeltour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
status: has PR The issue is being processed in a pull request type: maintenance The issue is related to a meta task (build system, dependency update, etc)
Projects
None yet
Milestone
v5.0.0-rc
Development

Successfully merging a pull request may close this issue.

feat: update Saxon library to v11.4 w3c/epubcheck
2 participants
@rdeltour @raducoravu