Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not report when linked resources are legit publication resources #1454

Closed
rdeltour opened this issue Dec 8, 2022 · 0 comments · Fixed by #1466
Closed

do not report when linked resources are legit publication resources #1454

rdeltour opened this issue Dec 8, 2022 · 0 comments · Fixed by #1466
Assignees
@rdeltour
Labels
status: has PR The issue is being processed in a pull request type: false-positive This issue is about valid content being incorrectly rejected
Milestone
v5.0.0-rc

Comments

@rdeltour
Copy link
Member

rdeltour commented Dec 8, 2022

The spec says:

Resources referenced from the link element are publication resources only when they are:

In all other cases (e.g., when linking to standalone [onix] or [xmp] records), the resources referenced are not publication resources (i.e., are not subject to core media type requirements) and EPUB creators MUST NOT list them in the manifest.

Currently, EPUBCheck reports OPF-067 ("The resource "…" must not be listed both as a "link" element in the package metadata and as a manifest item.") even for the two exceptions listed in the spec. For instance, spec example 33 (reference to a record embedded in an XHTML content document) is rejected by EPUBCheck.
@rdeltour rdeltour added status: accepted Ready to be further processed type: false-positive This issue is about valid content being incorrectly rejected labels Dec 8, 2022
@rdeltour rdeltour added this to the v5.0.0-rc milestone Dec 8, 2022
@rdeltour rdeltour self-assigned this Dec 8, 2022
rdeltour added a commit that referenced this issue Dec 23, 2022
@rdeltour
fix: allow links to resources embedded in content documents
74871c6 
This commit checks that the linked resource is not in the spine before
reporting `OPF-067` ("The resource "…" must not be listed both as a
"link" element in the package metadata and as a manifest item.").

Effectively, this allows package links to publication resources in the
two cases identified in the EPUB 3.3 specification:

> Resources referenced from the link element are publication resources
> only when they are:
> - referenced from the spine; or
> - included or embedded in an EPUB content document

Fix #1454
@rdeltour rdeltour mentioned this issue Dec 23, 2022
Merged
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request and removed status: accepted Ready to be further processed labels Dec 23, 2022
rdeltour added a commit that referenced this issue Jan 3, 2023
@rdeltour
fix: allow links to resources embedded in content documents
aaed7bb 
This commit checks that the linked resource is not in the spine before
reporting `OPF-067` ("The resource "…" must not be listed both as a
"link" element in the package metadata and as a manifest item.").

Effectively, this allows package links to publication resources in the
two cases identified in the EPUB 3.3 specification:

> Resources referenced from the link element are publication resources
> only when they are:
> - referenced from the spine; or
> - included or embedded in an EPUB content document

Fix #1454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
status: has PR The issue is being processed in a pull request type: false-positive This issue is about valid content being incorrectly rejected
Projects
None yet
Milestone
v5.0.0-rc
Development

Successfully merging a pull request may close this issue.

improve checks of package links w3c/epubcheck
1 participant
@rdeltour